[libmariadb] Fix OpenSSL feature option #14196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arves100
changed the title
arves100
changed the title
JackBoosY
added
the
category:port-bug
This was referenced Oct 26, 2020
JackBoosY
suggested changes
Oct 26, 2020
|
Updated |
JackBoosY
approved these changes
Oct 26, 2020
JackBoosY
added
info:reviewed
|
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libmariadb newer versions defines SSL support in a different way than before (as they added GNUTls support).
This commit replaces WITH_SSL=ON to WITH_SSL=OPENSSL to force libmariadb to link agains OpenSSL.
Without this changes, under any other platform than Windows, SSL support will be disabled, while on Windows it will rely on Windows libraries (it also seems to be, as reported in #13848 that automatic linking for such libraries is missing a library)
Linking issues reported in #13848 with drogon:x86-windows are fixed.