Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg] Remove hard-coded ApiKey from nuget push #14202

Merged
merged 1 commit into from
Oct 29, 2020
Merged

[vcpkg] Remove hard-coded ApiKey from nuget push #14202

merged 1 commit into from
Oct 29, 2020

Conversation

ekilmer
Copy link
Contributor

@ekilmer ekilmer commented Oct 24, 2020

Describe the pull request
After experimenting with vcpkg binary caching feature and trying to upload the built binaries to GitHub Packages using NuGet, I ran into a similar authentication issue as #12984.

This PR removes the hard-coded NuGet API key so that a user's specified key can be used in a VCPKG_BINARY_SOURCES environment variable.

This was my first time using NuGet and setting everything up with GitHub Packages, so if this hard-coded key name is somehow intentional, I'd like to know how to work around this or what a better binary caching setup would look like.

@ekilmer ekilmer marked this pull request as ready for review October 24, 2020 21:04
@NancyLi1013 NancyLi1013 added category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed requires:discussion labels Oct 26, 2020
ras0219
ras0219 approved these changes Oct 29, 2020
View reviewed changes
Copy link
Contributor

@ras0219 ras0219 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for using binary caching and extra thanks the fix!

I have tested this against ADO artifacts feeds and confirmed that it no longer needs an ApiKey parameter, so this LGTM.

@ras0219-msft ras0219-msft merged commit 0434ef7 into microsoft:master Oct 29, 2020
@ekilmer ekilmer deleted the nuget-fix-apikey branch October 29, 2020 22:39
@ras0219 ras0219 mentioned this pull request Dec 5, 2020
Merged
strega-nil pushed a commit to strega-nil/vcpkg that referenced this pull request May 5, 2021
@ekilmer
[vcpkg] Remove hard-coded ApiKey from nuget push (microsoft#14202)
799c002
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ras0219 ras0219 ras0219 approved these changes

@BillyONeal BillyONeal Awaiting requested review from BillyONeal

Assignees

@NancyLi1013 NancyLi1013

Labels
category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nugetconfig binary source ignores API key in config file
4 participants
@ekilmer @ras0219 @ras0219-msft @NancyLi1013