Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[szip, openssl] Fix problems with mingw #14460

Merged
merged 2 commits into from
Nov 9, 2020
Merged

[szip, openssl] Fix problems with mingw #14460

merged 2 commits into from
Nov 9, 2020

Conversation

longnguyen2004
Copy link
Contributor

Describe the pull request

@longnguyen2004 longnguyen2004 mentioned this pull request Nov 8, 2020
Closed
@JackBoosY JackBoosY added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Nov 8, 2020
Neumann-A
Neumann-A reviewed Nov 8, 2020
View reviewed changes
ports/szip/portfile.cmake Outdated Show resolved Hide resolved
PhoebeHui
PhoebeHui reviewed Nov 9, 2020
View reviewed changes
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @strega-nil, could you help further review?

@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Nov 9, 2020
@strega-nil strega-nil merged commit 9336ae3 into microsoft:master Nov 9, 2020
@longnguyen2004 longnguyen2004 deleted the szip-openssl-mingw branch November 10, 2020 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Neumann-A Neumann-A Neumann-A left review comments

@PhoebeHui PhoebeHui PhoebeHui left review comments

Assignees

@strega-nil strega-nil

@PhoebeHui PhoebeHui

Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[szip:x64-mingw-dynamic] Reason for Could not find proper second linker member
5 participants
@longnguyen2004 @PhoebeHui @Neumann-A @strega-nil @JackBoosY