Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[redis-plus-plus] Add c++17 feature #14762

Merged
merged 15 commits into from
Dec 1, 2020
Merged

[redis-plus-plus] Add c++17 feature #14762

merged 15 commits into from
Dec 1, 2020

Conversation

JonLiu1993
Copy link
Member

@JonLiu1993 JonLiu1993 commented Nov 25, 2020 •
edited
Loading

Describe the pull request

Build redis-plus-plus using define flag REDIS_PLUS_PLUS_CXX_STANDARD=17 can be solved

All featureas are tested successfully in the following triplets:

  • x86-windows
  • x64-windows
  • x64-windows-static

@JonLiu1993 JonLiu1993 added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Nov 25, 2020
JackBoosY
JackBoosY suggested changes Nov 25, 2020
View reviewed changes
ports/redis-plus-plus/portfile.cmake Outdated Show resolved Hide resolved
JackBoosY
JackBoosY suggested changes Nov 26, 2020
View reviewed changes
ports/redis-plus-plus/portfile.cmake Outdated Show resolved Hide resolved
JackBoosY
JackBoosY suggested changes Nov 26, 2020
View reviewed changes
ports/redis-plus-plus/CONTROL Outdated Show resolved Hide resolved
@JonLiu1993 JonLiu1993 changed the title Build using c++17 standard [redis-plus-plus] Add c++17 feature Nov 26, 2020
@JonLiu1993 JonLiu1993 added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist and removed category:port-bug The issue is with a library, which is something the port should already support labels Nov 26, 2020
@JonLiu1993 JonLiu1993 marked this pull request as ready for review November 27, 2020 07:19
JackBoosY
JackBoosY suggested changes Dec 1, 2020
View reviewed changes
ports/redis-plus-plus/portfile.cmake Outdated Show resolved Hide resolved
ports/redis-plus-plus/portfile.cmake Outdated Show resolved Hide resolved
ports/redis-plus-plus/portfile.cmake Outdated Show resolved Hide resolved
@NancyLi1013 NancyLi1013 added the info:reviewed Pull Request changes follow basic guidelines label Dec 1, 2020
@strega-nil strega-nil merged commit 8c3be9e into microsoft:master Dec 1, 2020
@strega-nil
Copy link
Contributor

Thanks @JonLiu1993 :)

@JonLiu1993 JonLiu1993 deleted the dev/Jon/redis-plus-plus branch June 9, 2021 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

@JackBoosY JackBoosY JackBoosY approved these changes

Assignees

@NancyLi1013 NancyLi1013

Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[redis-plus-plus] Build using c++17 standard
4 participants
@JonLiu1993 @strega-nil @NancyLi1013 @JackBoosY