Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libxml2] build failure with x64-linux-dynamic (Fix #14990) #14991

Merged
merged 3 commits into from
Dec 9, 2020
Merged

[libxml2] build failure with x64-linux-dynamic (Fix #14990) #14991

merged 3 commits into from
Dec 9, 2020

Conversation

klalumiere
Copy link
Contributor

Describe the pull request

Tested with the triplets x64-linux, x64-linux-dynamic and x64-windows (on a Windows machine)

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support requires:author-response labels Dec 8, 2020
@JackBoosY
Copy link
Contributor

Does libxml2 depend on libc? Or other ports depend on it?

@klalumiere
Copy link
Contributor Author

libxml2 depends on libiconv, as encoded in its CONTROL file. Then, libiconv is resolved as libc.so: the author of libiconv actually added a comment so that we know that this is expected (in CMakeCache.txt):

image

@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Dec 9, 2020
@BillyONeal BillyONeal merged commit 1d8728a into microsoft:master Dec 9, 2020
@BillyONeal
Copy link
Member

Thanks for your help!

@klalumiere klalumiere deleted the fix-14990 branch December 24, 2020 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[libxml2] build failure with x64-linux-dynamic
3 participants