-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[libspatialite] Update 5.0.0 #15040
[libspatialite] Update 5.0.0 #15040
Conversation
update from vcpkg
Both libspatialite and spatialite-tools depend on librttopo,After librttopo PR #15037 is merged, I will merge the code again. |
update from vcpkg
The modification of spatialite-tools is to make this PR static library compile without error, it will be updated in another PR #15039 |
@JackBoosY Can anyone review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This port installed the pkgconfig file on non-Windows, so I think we should add vcpkg_fixup_pkgconfig()
after vcpkg_install_make
when building non-Windows.
Thanks for the PR! |
* update to 5.0.0 * update * update * fix static build failed * remove fix-latin-literals.patch * Update portfile.cmake
@longhuan2018 Hi, yesterday I got a regression about
This seems to be caused by libspatialite using postgis when building, but not adding the postgis library to the link list when building spatialite-tools. Note the symbols are belong to postgis instead of geos. See documentation. |
Now libspatialite depends on librttopo, so if libspatialite is statically linked, librttopo also needs to be linked |
How can I reproduce this compilation error? Do need to download the latest vcpkg? |
@longhuan2018 Yes, do you have linux machine? Just install |
|
@longhuan2018 Note #15746 trying to disable |
ok |
update libspatialite to 5.0.0