Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libspatialite] Update 5.0.0 #15040

Merged
merged 8 commits into from
Dec 21, 2020

Conversation

longhuan2018
Copy link
Contributor

update libspatialite to 5.0.0

@longhuan2018
Copy link
Contributor Author

longhuan2018 commented Dec 10, 2020

Both libspatialite and spatialite-tools depend on librttopo,After librttopo PR #15037 is merged, I will merge the code again.

@longhuan2018
Copy link
Contributor Author

The modification of spatialite-tools is to make this PR static library compile without error, it will be updated in another PR #15039

@longhuan2018
Copy link
Contributor Author

@JackBoosY Can anyone review this PR?

@JackBoosY JackBoosY changed the title [libspatialite ]Update 5.0.0 [libspatialite] Update 5.0.0 Dec 21, 2020
@JackBoosY JackBoosY self-assigned this Dec 21, 2020
@JackBoosY JackBoosY added the category:port-update The issue is with a library, which is requesting update new revision label Dec 21, 2020
Copy link
Contributor

@JackBoosY JackBoosY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This port installed the pkgconfig file on non-Windows, so I think we should add vcpkg_fixup_pkgconfig() after vcpkg_install_make when building non-Windows.

@JackBoosY JackBoosY added info:reviewed Pull Request changes follow basic guidelines requires:author-response and removed info:reviewed Pull Request changes follow basic guidelines labels Dec 21, 2020
@JackBoosY JackBoosY added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Dec 21, 2020
@vicroms vicroms merged commit 05e79e9 into microsoft:master Dec 21, 2020
@vicroms
Copy link
Member

vicroms commented Dec 21, 2020

Thanks for the PR!

ryukw7 pushed a commit to ryukw7/vcpkg that referenced this pull request Dec 24, 2020
* update to 5.0.0

* update

* update

* fix static build failed

* remove fix-latin-literals.patch

* Update portfile.cmake
@JackBoosY
Copy link
Contributor

JackBoosY commented Jan 19, 2021

@longhuan2018 Hi, yesterday I got a regression about spatialite-tools:

/home/usr/work/vcpkg/installed/x64-linux/debug/lib/libspatialite.a(lwn_network.o): In function `geo_link_split':
lwn_network.c:(.text+0x26e7): undefined reference to `ptarray_construct'
lwn_network.c:(.text+0x2791): undefined reference to `ptarray_set_point4d'
lwn_network.c:(.text+0x27d2): undefined reference to `rtline_construct'
lwn_network.c:(.text+0x27fc): undefined reference to `ptarray_construct'
lwn_network.c:(.text+0x2860): undefined reference to `ptarray_set_point4d'
lwn_network.c:(.text+0x2884): undefined reference to `rtpoint_construct'
...

This seems to be caused by libspatialite using postgis when building, but not adding the postgis library to the link list when building spatialite-tools.
But I did not find the postgis library in the build logs of libspatialite.
Do you have any ideas?

Note the symbols are belong to postgis instead of geos. See documentation.

@longhuan2018
Copy link
Contributor Author

@longhuan2018 Hi, yesterday I got a regression about :spatialite-tools

/home/usr/work/vcpkg/installed/x64-linux/debug/lib/libspatialite.a(lwn_network.o): In function `geo_link_split':
lwn_network.c:(.text+0x26e7): undefined reference to `ptarray_construct'
lwn_network.c:(.text+0x2791): undefined reference to `ptarray_set_point4d'
lwn_network.c:(.text+0x27d2): undefined reference to `rtline_construct'
lwn_network.c:(.text+0x27fc): undefined reference to `ptarray_construct'
lwn_network.c:(.text+0x2860): undefined reference to `ptarray_set_point4d'
lwn_network.c:(.text+0x2884): undefined reference to `rtpoint_construct'
...

This seems to be caused by libspatialite using postgis when building, but not adding the postgis library to the link list when building spatialite-tools.
But I did not find the postgis library in the build logs of libspatialite.
Do you have any ideas?

Note the symbols are belong to postgis instead of geos. See documentation.

Now libspatialite depends on librttopo, so if libspatialite is statically linked, librttopo also needs to be linked

@longhuan2018
Copy link
Contributor Author

How can I reproduce this compilation error? Do need to download the latest vcpkg?

@JackBoosY
Copy link
Contributor

@longhuan2018 Yes, do you have linux machine? Just install spatialite-tools:x64-linux can repro this issue.

@longhuan2018
Copy link
Contributor Author

@longhuan2018 Yes, do you have linux machine? Just install spatialite-tools:x64-linux can repro this issue.
OK, I'll try first

@JackBoosY
Copy link
Contributor

@longhuan2018 Note #15746 trying to disable spatialite-tools results in pipeline test, so if your PR can successfully fix this regression, please leave a message in #15746 to close that PR.

@longhuan2018
Copy link
Contributor Author

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants