-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[libiconv] Updated typo in iconv share files location #15771
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackBoosY
changed the title
Updated typo in iconv share files location
[libiconv] Updated typo in iconv share files location
Jan 20, 2021
JackBoosY
added
the
category:port-bug
The issue is with a library, which is something the port should already support
label
Jan 20, 2021
Case issue? Interesting... |
JackBoosY
approved these changes
Jan 20, 2021
Neumann-A
reviewed
Jan 20, 2021
Sorry my mistake. |
JackBoosY
approved these changes
Jan 20, 2021
That is really strange. The Linux CI should have the same issue then. |
@Neumann-A Yes, our pipeline test should catch this regression, but not. |
Exactly, it's really strange that no one else had an issue with that. |
CMake Error at ports/libiconv/portfile.cmake:4 (file): file COPY cannot copy file "/root/dev/ExternalLibraries/vcpkg/ports/libiconv/vcpkg-cmake-wrapper.cmake" to "/root/dev/ExternalLibraries/vcpkg/packages/libiconv_x64-linux/share/iconv/vcpkg-cmake-wrapper.cmake": Success. Call Stack (most recent call first): scripts/ports.cmake:136 (include)
Co-authored-by: Alexander Neumann <30894796+Neumann-A@users.noreply.github.com>
JackBoosY
added
info:reviewed
Pull Request changes follow basic guidelines
and removed
info:reviewed
Pull Request changes follow basic guidelines
labels
Jan 22, 2021
Already merged from master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category:port-bug
The issue is with a library, which is something the port should already support
info:reviewed
Pull Request changes follow basic guidelines
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
[docker][libiconv] build failure #15755