Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libiconv] Updated typo in iconv share files location #15771

Merged
merged 5 commits into from
Jan 25, 2021

Conversation

ludekvodicka
Copy link
Contributor

Describe the pull request

@JackBoosY JackBoosY self-assigned this Jan 20, 2021
@JackBoosY JackBoosY changed the title Updated typo in iconv share files location [libiconv] Updated typo in iconv share files location Jan 20, 2021
@JackBoosY JackBoosY added the category:port-bug The issue is with a library, which is something the port should already support label Jan 20, 2021
@JackBoosY
Copy link
Contributor

Case issue? Interesting...

@JackBoosY
Copy link
Contributor

Sorry my mistake.

@Neumann-A
Copy link
Contributor

@JackBoosY:

That is really strange. The Linux CI should have the same issue then.

@JackBoosY
Copy link
Contributor

@Neumann-A Yes, our pipeline test should catch this regression, but not.

@ludekvodicka
Copy link
Contributor Author

Exactly, it's really strange that no one else had an issue with that.

@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Jan 21, 2021
ludekvodicka and others added 5 commits January 21, 2021 10:05
CMake Error at ports/libiconv/portfile.cmake:4 (file):
  file COPY cannot copy file
  "/root/dev/ExternalLibraries/vcpkg/ports/libiconv/vcpkg-cmake-wrapper.cmake"
  to
  "/root/dev/ExternalLibraries/vcpkg/packages/libiconv_x64-linux/share/iconv/vcpkg-cmake-wrapper.cmake":
  Success.
Call Stack (most recent call first):
  scripts/ports.cmake:136 (include)
Co-authored-by: Alexander Neumann <30894796+Neumann-A@users.noreply.github.com>
@JackBoosY JackBoosY added info:reviewed Pull Request changes follow basic guidelines and removed info:reviewed Pull Request changes follow basic guidelines labels Jan 22, 2021
@JackBoosY
Copy link
Contributor

Already merged from master.

@dan-shaw dan-shaw merged commit c997738 into microsoft:master Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants