[boost-concept-check] Fix warning C4834 when install pagmo2 #15887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cheney-W
added
category:port-bug
NancyLi1013
approved these changes
Jan 26, 2021
|
@StarGate-One |
added 2 commits
January 31, 2021 22:06
|
@Cheney-W Thank you a-lot. 👍😊 |
NancyLi1013
approved these changes
Feb 2, 2021
|
@ras0219-msft Could you please help review and merge this PR? Thanks. |
|
LGTM, thanks for getting it checked against upstream! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
Since the change: microsoft/STL#1474 , [nodiscard] was added before some operator() function, this change causes the warning C4834: discarding return value of function with 'nodiscard' attribute occurs when install port pagmo2.
The change of STL is by design.
The warning was reported in the concept_check.hpp file, which comes from the dependency boost-concept-check of pagmo2，so I add a patch to modify the source code of boost-concept-check.