Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg baseline][osgearth] Fix and add dependency tinyxml #15900

Merged
merged 2 commits into from
Jan 27, 2021

Conversation

JackBoosY
Copy link
Contributor

Since osgearth has built-in tinyxml and put its codes in the same source path, osgearth always uses the internal tinyxml symbol declaration first, no matter whether you choose to use internal or external tinyxml.

Related: gwaldron/osgearth#1002

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Jan 27, 2021
@JackBoosY JackBoosY changed the title [osgearth] Fix and add dependency tinyxml [vcpkg baseline][osgearth] Fix and add dependency tinyxml Jan 27, 2021
@NancyLi1013 NancyLi1013 added the info:reviewed Pull Request changes follow basic guidelines label Jan 27, 2021
@NancyLi1013 NancyLi1013 mentioned this pull request Jan 27, 2021
2 tasks
@dan-shaw dan-shaw merged commit f53d979 into microsoft:master Jan 27, 2021
@JackBoosY JackBoosY deleted the dev/jack/fix_baseline_20210127 branch January 28, 2021 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants