Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[openvdb] update to v8.0.0 #16034

Merged
merged 13 commits into from
Jul 16, 2021
Merged

Conversation

JonLiu1993
Copy link
Member

Describe the pull request

Update openvdb to the latest version 8.0.0 and add AX feature

All features are tested successfully in the following trip;ets:

  • x86-windows
  • x64-windows
  • x64-windows-static

@JonLiu1993 JonLiu1993 added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal This PR or Issue was filed by the vcpkg team. category:port-update The issue is with a library, which is requesting update new revision labels Feb 4, 2021
@JonLiu1993 JonLiu1993 marked this pull request as ready for review February 4, 2021 07:13
@NancyLi1013 NancyLi1013 marked this pull request as draft February 9, 2021 09:23
@orbingol
Copy link

I was wondering if there are any updates on this PR.

I also would like to add a note: OpenVDB compiles and links against the latest version of blosc on Windows as well as v1.5.0 of blosc library. However, it requires blosc v1.5.0 on Linux (tested with Ubuntu 18.04) and macOS (tested with Catalina). It compiles but does not link when blosc is NOT v1.5.0 on Linux and macOS.

Is there a way to add blosc v1.5.0 instead of the latest available via vcpkg?

@JonLiu1993
Copy link
Member Author

I was wondering if there are any updates on this PR.

I also would like to add a note: OpenVDB compiles and links against the latest version of blosc on Windows as well as v1.5.0 of blosc library. However, it requires blosc v1.5.0 on Linux (tested with Ubuntu 18.04) and macOS (tested with Catalina). It compiles but does not link when blosc is NOT v1.5.0 on Linux and macOS.

Is there a way to add blosc v1.5.0 instead of the latest available via vcpkg?

@orbingol ,If you need to use blosc v1.5.0 version, you can submit an update issue, I can update to the latest version and fix this pr together.

@orbingol
Copy link

orbingol commented Mar 1, 2021

@JonLiu1993 I mean OpenVDB needs to use blosc v1.5.0 for Linux and macOS. I believe blosc v1.5.0 would be a downgrade for the existing port, v1.5.0 was released on Nov 7th, 2014 according to the GH release page.

Regarding OpenVDB, here are some references:

Since OpenVDB needs this specific version of blosc, I was wondering if it is possible to create a port, like blosc150, for use with OpenVDB till they support a more recent version of blosc. blosc v1.5.0 could also be integrated into the build step of OpenVDB. I don't think any other library would depend on such an old version of blosc. I can surely open an issue referencing this PR.

I am guessing installing different versions of the ports is still WIP in vcpkg, and creating a port as I suggested might solve OpenVDB Linux and macOS issues till the official solution comes. It looks like you were also able to compile against the windows triples.

@JonLiu1993 JonLiu1993 marked this pull request as ready for review April 9, 2021 09:47
ports/openvdb/portfile.cmake Outdated Show resolved Hide resolved
@NancyLi1013 NancyLi1013 added the info:reviewed Pull Request changes follow basic guidelines label Jul 16, 2021
@BillyONeal
Copy link
Member

@JonLiu1993 I mean OpenVDB needs to use blosc v1.5.0 for Linux and macOS. I believe blosc v1.5.0 would be a downgrade for the existing port, v1.5.0 was released on Nov 7th, 2014 according to the GH release page.

You can add another version; accessing it though would require a specific overridden version.

I am guessing installing different versions of the ports is still WIP in vcpkg

Different versions of ports at the same time is fundamentally impossible; it isn't a vcpkg limitation, it is a C++ limitation. It breaks the ODR.

That all seems like a preexisting problem not directly related to this PR so I'll merge it once build passes on the current infrastructure.

@BillyONeal BillyONeal merged commit 4d2568e into microsoft:master Jul 16, 2021
@BillyONeal
Copy link
Member

Thanks for your contribution! :)

@JonLiu1993 JonLiu1993 deleted the dev/Jon/openvdb branch July 16, 2021 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist category:port-update The issue is with a library, which is requesting update new revision info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[openvdb] update to v8.0.0
4 participants