Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[magnum,-plugins] Fix deployment of plugin types and incorrect removal of plugin lib dir on unix #16245

Merged
merged 4 commits into from
Feb 18, 2021
Merged

[magnum,-plugins] Fix deployment of plugin types and incorrect removal of plugin lib dir on unix #16245

merged 4 commits into from
Feb 18, 2021

Conversation

Squareys
Copy link
Contributor

Hi all,

this PR fixes a couple of issues with the deployment of plugins:

  • SceneConverter and ShaderConverter plugins were not deployed
  • "MagnumTrade.dll" that was added in since original creation of magnumdeploy.ps1 allows better detection of when certain plugin types need to be deployed
  • On Unix (support for which was added since original creation of magnumdeploy.ps1 also), deletion of the lib/magnum(-d) directories causes issues, hence now wrapped in if(WIN32)

Best,
Jonathan

@Squareys
[magnum] Correctly deploy shaderconverter and sceneconverter plugins
b7a217b 
Signed-off-by: Squareys <squareys@googlemail.com>
@Squareys
[magnum,-plugins] Only remove plugin lib dirs for Windows platforms
aa3b023 
Signed-off-by: Squareys <squareys@googlemail.com>
@Squareys Squareys mentioned this pull request Feb 16, 2021
Closed
@mosra mosra mentioned this pull request Feb 16, 2021
Open
@Squareys
[magnum,-plugins] Clean up deletion of plugin libs and clarify in com…
398d68a 
…ment

Signed-off-by: Squareys <squareys@googlemail.com>
@PhoebeHui PhoebeHui self-assigned this Feb 18, 2021
@PhoebeHui PhoebeHui added the category:port-bug The issue is with a library, which is something the port should already support label Feb 18, 2021
PhoebeHui
PhoebeHui approved these changes Feb 18, 2021
View reviewed changes
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Squareys, thanks for the PR!

@PhoebeHui
Copy link
Contributor

The gsoap failures doesn't relate to this issue, it would be fixed by #16270. I will rerun the CI test after the PR merged.

@ras0219-msft
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ras0219-msft ras0219-msft merged commit e7377f7 into microsoft:master Feb 18, 2021
@ras0219-msft
Copy link
Contributor

This looks great to me, thanks for the fix!

@Squareys Squareys mentioned this pull request Feb 24, 2021
Closed
@mosra mosra mentioned this pull request Oct 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhoebeHui PhoebeHui PhoebeHui approved these changes

Assignees

@PhoebeHui PhoebeHui

Labels
category:port-bug The issue is with a library, which is something the port should already support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Squareys @PhoebeHui @ras0219-msft