Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[boost-context] fix linux -> windows cross compile #16378

Merged
merged 2 commits into from
Feb 26, 2021
Merged

[boost-context] fix linux -> windows cross compile #16378

merged 2 commits into from
Feb 26, 2021

Conversation

autoantwort
Copy link
Contributor

Describe the pull request

@cenit
Copy link
Contributor

cenit commented Feb 23, 2021

usually boost port files are auto generated. it might be better to fix the generating script in order to not loose your mods the next update

@autoantwort
Copy link
Contributor Author

Yeah the script https://github.com/microsoft/vcpkg/blob/master/scripts/boost/generate-ports.ps1#L185 uses the b2-options.cmake.in file and creates the same code as I

@PhoebeHui PhoebeHui added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Feb 24, 2021
PhoebeHui
PhoebeHui approved these changes Feb 24, 2021
View reviewed changes
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR!

@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Feb 24, 2021
@ras0219-msft
Copy link
Contributor

This PR LGTM, however should this fragment always be applied to all boost builds? Or is boost-context the only library that cares about abi=ms?

@autoantwort
Copy link
Contributor Author

This PR LGTM, however should this fragment always be applied to all boost builds? Or is boost-context the only library that cares about abi=ms?

No this is a boost-context only option. See here.

@ras0219-msft ras0219-msft merged commit e25b620 into microsoft:master Feb 26, 2021
@ras0219-msft
Copy link
Contributor

LGTM, thanks again!

@autoantwort autoantwort mentioned this pull request Mar 1, 2021
Merged
@autoantwort autoantwort deleted the boost-context branch September 1, 2021 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhoebeHui PhoebeHui PhoebeHui approved these changes

@ras0219-msft ras0219-msft ras0219-msft approved these changes

Assignees

@PhoebeHui PhoebeHui

Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[boost-context] build failure (linux -> windows cross compile)
4 participants
@autoantwort @cenit @ras0219-msft @PhoebeHui