Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[scripts-audit] vcpkg_common_definitions #16393

Conversation

strega-nil
Copy link
Contributor

@strega-nil strega-nil commented Feb 24, 2021

See issue #16188.

Part of the "merge 2021-02-26 EOD" group.

@JackBoosY JackBoosY added category:scripts-audit Part of the scripts audit effort. info:internal This PR or Issue was filed by the vcpkg team. labels Feb 25, 2021
* pull the cmake doc comment parsing out into its own function
* support cmake helper ports
* add real support for deprecation, as opposed to ad-hoc
@strega-nil strega-nil force-pushed the scripts-audit/vcpkg_common_definitions branch from 4867d21 to 9476487 Compare February 26, 2021 20:40
@strega-nil
Copy link
Contributor Author

Closing in favor of a single PR that contains all of these PRs. (to avoid destroying the CI system)

@strega-nil strega-nil closed this Feb 26, 2021
strega-nil added a commit to strega-nil/vcpkg that referenced this pull request Feb 26, 2021
strega-nil added a commit that referenced this pull request Feb 28, 2021
* [scripts-audit rollup] PR #16419

* pull the cmake doc comment parsing out into its own function
* support cmake helper ports
* add real support for deprecation, as opposed to ad-hoc

* [scripts-audit rollup] PR #16192

* add a z_ in front of internal functions
* move internal functions out

set feature_vars again in parent scope

* [scripts-audit rollup] PR #16309

Audit vcpkg_copy_pdbs

* [scripts-audit rollup] PR #16304

* Fix usage, documentation

* [scripts-audit rollup] PR #16393

* [scripts-audit rollup] PR #16377

Deprecate `vcpkg_*_cmake` in favor of `vcpkg_cmake_*` from the
`vcpkg-cmake` port, as well as `vcpkg_fixup_cmake_targets`
in favor of `vcpkg_cmake_config_fixup` from the
`vcpkg-cmake-config` port.
@strega-nil strega-nil deleted the scripts-audit/vcpkg_common_definitions branch March 1, 2021 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:scripts-audit Part of the scripts audit effort. info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants