[harfbuzz] work around upstream SameFileError #16621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During the configuration of harfbuzz several Python scripts are invoked that are supposed to copy some files. For some reason however the scripts end up being instructed to copy files to themselves at which point a SameFileError is risen, causing the build to fail. This is a workaround for the underlaying issue that is deemed to be usptream. The upstream issues are - mesonbuild/meson#8375 - harfbuzz/harfbuzz#2870 The workaround is to add a patch that makes sure these scripts check whether source and target file are the same and only invoking the copy action if they are not. Fixes microsoft#16262
|
|
JackBoosY
added
category:port-bug
|
cc @Neumann-A for review this PR. |
|
Maybe I should also mention that I proposed the same changes upstream, but they were neglected as they are only hiding the underlaying problem. While that is of course true, I think vcpkg should rather hide an upstream problem than to fail the build because of it ☝️ |
|
@JackBoosY LGTM if it works. |
|
This worked at least for me on the machine (or rather VM) that did create the problems before. Haven't tested on any other system though 🤷 |
|
Agreed, LGTM. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the configuration of harfbuzz several Python scripts are invoked
that are supposed to copy some files. For some reason however the
scripts end up being instructed to copy files to themselves at which
point a SameFileError is risen, causing the build to fail.
This is a workaround for the underlaying issue that is deemed to be
usptream. The upstream issues are
The workaround is to add a patch that makes sure these scripts check
whether source and target file are the same and only invoking the copy
action if they are not.
Fixes #16262