[openjpeg] 16645 Fix compile w/features jp3d,jpip,jpwl,mj2 triplet x64-windows VS 2019 ver 16.9.1

[StarGate-One]

Describe the pull request

1. With update to VS 2019 to ver 16.9.1, the openjpeg with any of the features jp3d,jpip,jpwl,mj2 failed to compile under triplet x64-windows.
2. Created patch fix-lrintf-to-opj_lrintf.patch to change /src/lib/openmj2/opj_includes.h line 96:
   • From: static INLINE long lrintf(float f)
   • To: static INLINE long opj_lrintf(float f)
3. Modified portfile.cmake to apply patch
4. Converted CONTROL file to vcpkg.json file
5. Updated port-version to 3
6. ran vcpkg x-add-version openjpeg to Update json file
7. Tested locally on VS 2017/2019 x64-windows triplet
8. Reformatted vcpkg.json file
9. Updated port-version to 4

• What does your PR fix? Fixes [openjpeg] build failure x64-windows with features (jp3d,jpip,jpwl,mj2) on VS 2019 latest update 16.9.1 #16645

• Which triplets are supported/not supported? No changes should effect supported/not supported triplets.

• Have you updated the CI baseline? No changes should effect CI baseline.

• Does your PR follow the maintainer guide? Yes I believe so.

[NancyLi1013]

Hi @StarGate-One

Thanks for fixing this issue.

Since upstream suggests vcpkg to only support openjp2. Please see uclouvain/openjpeg#1333 (comment)

So for other features in vcpkg, I'm not sure if it's necessary to add them now.

We have known the way to fix the problem, I think upstream also have known this. But why do they not support other features?

What's your opinion?

[StarGate-One]

Hi @NancyLi1013

1. I agree with your review changes - I clicked on commit suggestion for each one.
2. So we have the current version fixed.
3. Also I agree on not adding the new features or removing any unsupported features from upstream into vcpkg until the requirement is needed to upgrade to a newer version.

Thank you for your assistance/help.

• I will try to do better next time, I got caused myself to get messed up converting the CONTROL file to vcpkg.json file.
• Even though the format looked correct based on the CONTROL file, it seems vcpkg wants the json file to have features sorted alphabetically and change the windows carriage returns to unix line feeds.

Have a super wonderful weekend!!! 😊✨👏👍

[NancyLi1013]

For the failure on x86-windows:

Found the following errors:
Error: While reading versions for port openjpeg from file: C:\a\1\s\versions\o-\openjpeg.json
       File declares version `2.3.1#3` with scheme: `version-string`.
       But local port declares the same version with a different scheme: `version-semver`.
       Version must be unique even between different schemes.
       Run:

           vcpkg x-add-version openjpeg --overwrite-version

       to overwrite the declared version's scheme.

You can run vcpkg x-add-version openjpeg --overwrite-version and then submit the changes.

[NancyLi1013]

Thanks for your instant response @StarGate-One.

You have done great work now. 😊

Also you can update the format in portfile.cmake if you have enough time to do this work.

Since I cannot review them directly via suggested change. Of course, this is not related with your changes, just for looking more clear or tidy.

[ras0219-msft]

LGTM, thanks for the fix! I agree that given upstream's position we should probably not offer the extra features.