Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[boost-context] support android #16930

Merged
merged 1 commit into from
Apr 30, 2021
Merged

[boost-context] support android #16930

merged 1 commit into from
Apr 30, 2021

Conversation

huangqinjin
Copy link
Contributor

No description provided.

@PhoebeHui PhoebeHui self-assigned this Mar 29, 2021
@PhoebeHui PhoebeHui added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Mar 29, 2021
PhoebeHui
PhoebeHui requested changes Apr 1, 2021
View reviewed changes
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@huangqinjin, thanks for the PR!

ports/boost-build/portfile.cmake Show resolved Hide resolved
PhoebeHui
PhoebeHui approved these changes Apr 22, 2021
View reviewed changes
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @strega-nil, could you help further review?

You see the abi info from https://github.com/boostorg/context/blob/master/doc/reference.qbk.

@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Apr 22, 2021
@strega-nil-ms
Copy link
Contributor

Cool, LGTM. Thanks @huangqinjin

@strega-nil-ms strega-nil-ms merged commit 8badb23 into microsoft:master Apr 30, 2021
@huangqinjin huangqinjin deleted the boost-context-android branch May 30, 2021 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurybura yurybura yurybura left review comments

@PhoebeHui PhoebeHui PhoebeHui approved these changes

Assignees

@PhoebeHui PhoebeHui

Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@huangqinjin @strega-nil-ms @yurybura @PhoebeHui