Libspatialite remove cflags from vcpkg_configure_make options #17024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackBoosY
suggested changes
Apr 2, 2021
JackBoosY
added
category:port-bug
|
The flag is no longer needed with current libspatialite versions that support newer proj versions. And once proj is bumped to 8.0 this will even cause an error, so +1 on removing the define. |
|
The flag used to enable the legacy api in the proj headers |
JackBoosY
approved these changes
Apr 5, 2021
JackBoosY
added
info:reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Libspatialite remove cflags from vcpkg_configure_make options
This flag do not mentioned in sources
What does your PR fix? Fixes for PR [android] vcpkg_configure_make correct set flags for android build #15605
Which triplets are supported/not supported? same
Have you updated the CI baseline? no
Does your PR follow the maintainer guide? yes