Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libmariadb] Fix build error with cmake 3.20.0 #17113

Merged
merged 4 commits into from
Apr 7, 2021
Merged

[libmariadb] Fix build error with cmake 3.20.0 #17113

merged 4 commits into from
Apr 7, 2021

Conversation

NancyLi1013
Copy link
Contributor

Describe the pull request

Build error in cmake 3.20.0 with the following errors:

CMake Error at cmake/ConnectorName.cmake:30 (ENDMACRO):
  Flow control statements are not properly nested.
Call Stack (most recent call first):
  CMakeLists.txt:424 (INCLUDE)

The fix from upstream mariadb-corporation/mariadb-connector-c@242cab8c

Note: No need to test features.

@NancyLi1013 NancyLi1013 added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Apr 6, 2021
JackBoosY
JackBoosY suggested changes Apr 6, 2021
View reviewed changes
ports/libmariadb/CONTROL Outdated Show resolved Hide resolved
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Apr 7, 2021
@vicroms vicroms merged commit 88e0310 into microsoft:master Apr 7, 2021
@glennpj glennpj mentioned this pull request Apr 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackBoosY JackBoosY JackBoosY approved these changes

Assignees

@JackBoosY JackBoosY

Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[libmariadb] build failure with cmake 3.20.0
3 participants
@NancyLi1013 @JackBoosY @vicroms