Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libosip2] Update to 5.2.0 and add windows support #17321

Merged
merged 13 commits into from
Apr 30, 2021
Merged

[libosip2] Update to 5.2.0 and add windows support #17321

merged 13 commits into from
Apr 30, 2021

Conversation

NancyLi1013
Copy link
Contributor

Describe the pull request

Update to latest version 5.2.0 and also add support for Windows platform.

arm and arm64 are not supported on Windows platform.

Note: No feature needs to test.

@NancyLi1013 NancyLi1013 added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal This PR or Issue was filed by the vcpkg team. category:port-update The issue is with a library, which is requesting update new revision labels Apr 16, 2021
@NancyLi1013 NancyLi1013 mentioned this pull request Apr 16, 2021
Closed
@JackBoosY
Copy link
Contributor

LGTM.

@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Apr 23, 2021
strega-nil-ms
strega-nil-ms suggested changes Apr 29, 2021
View reviewed changes
Copy link
Contributor

@strega-nil-ms strega-nil-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes are required to the calls to vcpkg_install_msbuild

ports/libosip2/portfile.cmake Outdated Show resolved Hide resolved
ports/libosip2/portfile.cmake Outdated Show resolved Hide resolved
ports/libosip2/portfile.cmake Outdated Show resolved Hide resolved
ports/libosip2/portfile.cmake Outdated Show resolved Hide resolved
@JackBoosY JackBoosY removed the info:reviewed Pull Request changes follow basic guidelines label Apr 30, 2021
@NancyLi1013
Copy link
Contributor Author

Thanks for your review suggestions @strega-nil-ms

All have been done!

@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Apr 30, 2021
@strega-nil-ms strega-nil-ms merged commit d790cb6 into microsoft:master Apr 30, 2021
@strega-nil-ms
Copy link
Contributor

Thanks @NancyLi1013 :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackBoosY JackBoosY JackBoosY approved these changes

@strega-nil-ms strega-nil-ms Awaiting requested review from strega-nil-ms

Assignees

@JackBoosY JackBoosY

Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist category:port-update The issue is with a library, which is requesting update new revision info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

libosip2 build failure
3 participants
@NancyLi1013 @JackBoosY @strega-nil-ms