[infoware] Bump version to 0.6.0 #17597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You have to, otherwise the pipeline will fail. |
|
Well, even if I had run it I wouldn't've gotten far: That being said, I've also updated the versions in baseline.json, which is the only other place that contains "infoware" |
|
Maybe try this in the |
|
|
|
Can you run |
autoantwort
reviewed
May 1, 2021
ports/infoware/vcpkg.json
Outdated
| "version-string": "0.5.5", | ||
| "port-version": 1, | ||
| "version-string": "0.6.0", | ||
| "port-version": 0, |
There was a problem hiding this comment.
Suggested change
| "port-version": 0, |
The port-version is 0 by default, so you can/must remove this line.
|
Sure, why not: |
|
Ok, I only wanted to know if it also return the same error :) const auto local_repo = this->root / fs::u8path(".git");
const auto path_with_separator =
Strings::concat(fs::u8string(this->builtin_ports_directory()), Files::preferred_separator);
const auto git_cmd = git_cmd_builder(*this, local_repo, this->root)
.string_arg("ls-tree")
.string_arg("-d")
.string_arg("HEAD")
.string_arg("--")
.path_arg(path_with_separator);
auto output = System::cmd_execute_and_capture_output(git_cmd);
if (output.exit_code != 0)
return Strings::format("Error: Couldn't get local treeish objects for ports.\n%s", output.output);So it seems that |
|
Hm, And, indeed: That's latest git off MSYS2 (2.31.1). |
JackBoosY
added
the
category:port-update
|
Does this need anything else? |
|
Do you have another git version installed? |
|
no |
AFAICT, the trouble starts with the last parameter:
So this needs a change in vcpkg-tool. |
|
Indeed, Funnily enough, the only mention of ls-tree in the vcpkg-tool repo is const auto local_repo = this->root / fs::u8path(".git");
const auto git_cmd = git_cmd_builder({}, {})
.string_arg("-C")
.path_arg(this->builtin_ports_directory())
.string_arg("ls-tree")
.string_arg("-d")
.string_arg("HEAD")
.string_arg("--");
auto output = System::cmd_execute_and_capture_output(git_cmd);
if (output.exit_code != 0)
return Strings::format("Error: Couldn't get local treeish objects for ports.\n%s", output.output);and not whatever got posted above, and that will in fact work; that doesn't mean the bootstrap script downloads a binary that has it, but who knows. |
|
Managed to build vcpkg off git and run the infernal subcommand. Why it doesn't just use libgit2 instead remains firmly beyond me, but whatever. |
It seems that is was changed 14 hours ago in microsoft/vcpkg-tool#69 |
|
Indeed, and a build therewith fixed the issue and let me regenerate the version. |
|
Thanks @nabijaczleweli :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix? The infoware version being out of date.
Which triplets are supported/not supported? Same ones. Have you updated the CI baseline? Still pretty sure I didn't.
Does your PR follow the maintainer guide? Likewise I hope it still does.
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result? No, I just updated it.