[ffmpeg] fix optional X11 platform dependencies #17625
Conversation
|
I forgot to mention this above, but whilst at it, I've also added Xext and Xv as dependent libraries, since these were listed in the ffmpeg configure script. |
JackBoosY
added
the
category:port-bug
|
Ping @cenit @Neumann-A for review this PR. |
|
@mcmtroffaes is doing a wonderful job with ffmpeg port! |
|
unrelated to this PR directly but still relevant for CI tests: opencv on uwp architectures (arm and x64) is now (again) a cascade failure. Again, undetected, it has fallen to this status which means that PR can break it without noticing.... when did it happen?? luckily there is no x11 on uwp platform, but in principle the problem is again there and any pr can break it without any red mark (i keep opencv under strict control also because it's an ffmpeg consuming port, so it's useful to see regressions in FindFFMPEG.cmake)... |
|
@cenit I still want to address that someday but having been load balanced elsewhere it's going to be a while before I have a chance to look. Starting to move things out of our wrapper powershell scripts (like analyze-test-results.ps1) and into |
|
I will try my best if/when possible to help you on this front. Cannot promise anything |
|
Conflicts resolved. |
|
@mcmtroffaes you'll need to merge with latest please :) |
|
Sure, merged again. |
|
Awesome, thanks @mcmtroffaes :D |
What does your PR fix?
If X11 is not installed on the system, ffmpeg gets compiled without X11 support, however the FindFFMPEG script will still add X11 to the list of platform dependent libraries, leading to linking errors (see for instance here). This PR fixes that issue.
Which triplets are supported/not supported? Have you updated the CI baseline?
No changes, baseline not updated.
Does your PR follow the maintainer guide?
Yes.
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes.