Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ffmpeg] update to upstream version 4.4 #17735

Merged
merged 14 commits into from
May 18, 2021

Conversation

mcmtroffaes
Copy link
Contributor

  • What does your PR fix?

    • Updates to latest upstream version of ffmpeg.
    • Updates manifest to use the new json format.
    • Removed avresample as default feature (it has been a deprecated component for a very long time, is not built by default by the upstream configure file, and has been removed in the upstream ffmpeg master branch).
    • The libwavpack support was removed upstream in this version (there's a native codec so no loss in functionality), whence I've removed the related feature and patches correspondingly.
  • Which triplets are supported/not supported? Have you updated the CI baseline?

    No changes.

  • Does your PR follow the maintainer guide?

    Yes, to the best of my knowledge.

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes.

@mcmtroffaes
Copy link
Contributor Author

This is a very new experience: linux, arm, and osx builds are passing but windows builds are failing. 😄

I cannot reproduce this locally so far (tested ffmpeg[all,all-gpl,all-nonfree]:x86-windows, awaiting other triplets...). It fails quite far into the build after about 16 minutes, so I wonder if this is MSVC running out of memory on azure. I've had to apply https://trac.ffmpeg.org/ticket/9019 on appveyor myself, but I never posted it here since it seemed to be an appveyor-only issue. Is it possible to see the build log, or at least the tail of the log?

@JackBoosY JackBoosY self-assigned this May 8, 2021
@JackBoosY JackBoosY added the category:port-update The issue is with a library, which is requesting update new revision label May 8, 2021
@JackBoosY
Copy link
Contributor

libavfilter/vf_scale_cuda_bicubic.ptx.c(3601): fatal error C1060: compiler is out of heap space

@JackBoosY
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mcmtroffaes
Copy link
Contributor Author

Thanks for the log - it's the cuda error as suspected. I'll update it with the patch.

@mcmtroffaes
Copy link
Contributor Author

Looks fixed now. It should work on linux too, maybe it fails on azure due to xxd not being installed? Anyway, I've worked around that by restricting the patch to windows targets.

@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label May 10, 2021
@dan-shaw dan-shaw merged commit 44e8841 into microsoft:master May 18, 2021
@mcmtroffaes mcmtroffaes deleted the feature/ffmpeg-4.4 branch May 18, 2021 07:16
@mcmtroffaes
Copy link
Contributor Author

Thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants