[yomm2] new port #17886
Merged
[yomm2] new port #17886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonLiu1993
added
the
category:new-port
|
Please get failure logs here. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
JackBoosY
suggested changes
May 13, 2021
FabienPean
force-pushed
the
port/yomm2
branch
2 times, most recently
from
2dd61e2
to
9fb552c
Compare
|
Note that dependency to |
FabienPean
force-pushed
the
port/yomm2
branch
2 times, most recently
from
60d8b4c
to
7d27897
Compare
|
I added a patch to fix uwp and osx build in vcpkg. This should be removed in the next version of yomm2 thanks to an update of the CMakeLists of the lib. The CI does not crash anymore on this port, so I think it is ready for review. |
|
Depends on #17983. |
JackBoosY
added
depends:different-pr
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
JackBoosY
approved these changes
May 20, 2021
ras0219-msft
approved these changes
May 24, 2021
FabienPean
force-pushed
the
port/yomm2
branch
2 times, most recently
from
bc0b237
to
c9aaf10
Compare
JackBoosY
approved these changes
May 26, 2021
JackBoosY
added
info:reviewed
|
Thanks for the quick response! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new port for library yomm2. Note that dependency of Boost libs are not resolved properly (#17882 #17848)
Which triplets are supported/not supported? Have you updated the CI baseline?
Normally all, waiting for CI
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes
If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/