Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[soil2] Update version #18453

Merged
merged 7 commits into from
Jul 23, 2021
Merged

[soil2] Update version #18453

merged 7 commits into from
Jul 23, 2021

Conversation

stijnherfst
Copy link
Contributor

An update for SOIL2 to the newest commit with minimal changes.

  • What does your PR fix?

Updates version

  • Which triplets are supported/not supported? Have you updated the CI baseline?

All previously supported triplets

Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

I'm confused by this. I've ran it, but no changes were made.

@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Jun 15, 2021
@JonLiu1993
Copy link
Member

@stijnherfst ,Thanks for your pr .
please run the command "./vcpkg x-add-version soil2 --overwrite-version" then commit the changes again

JonLiu1993
JonLiu1993 reviewed Jun 17, 2021
View reviewed changes
ports/soil2/CONTROL Outdated Show resolved Hide resolved
@stijnherfst
Copy link
Contributor Author

Is this not being merged in as it still has the requires:author-response flag? It seems ready to be merged.

@JonLiu1993 JonLiu1993 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Jun 29, 2021
@JonLiu1993
Copy link
Member

Is this not being merged in as it still has the requires:author-response flag? It seems ready to be merged.

Sorry to reply you so late, please wait for pr to be merged

ras0219-msft
ras0219-msft approved these changes Jul 1, 2021
View reviewed changes
Copy link
Contributor

@ras0219-msft ras0219-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@JonLiu1993 JonLiu1993 removed the info:reviewed Pull Request changes follow basic guidelines label Jul 2, 2021
@JonLiu1993
Copy link
Member

@stijnherfst,Please take a look:

CMake Error at ports/soil2/portfile.cmake:9 (file):
  file COPY cannot find "C:/a/1/s/ports/soil2/soil2ConfigVersion.cmake.in":
  No such file or directory.
Call Stack (most recent call first):
  scripts/ports.cmake:139 (include)

PhoebeHui
PhoebeHui approved these changes Jul 20, 2021
View reviewed changes
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Jul 20, 2021
@vicroms vicroms merged commit 549d7cd into microsoft:master Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonLiu1993 JonLiu1993 JonLiu1993 approved these changes

@PhoebeHui PhoebeHui PhoebeHui approved these changes

@ras0219-msft ras0219-msft ras0219-msft approved these changes

Assignees

@JonLiu1993 JonLiu1993

Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@stijnherfst @JonLiu1993 @ras0219-msft @PhoebeHui @vicroms @ras0219