Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[openssl] Fix x86-osx -> arm64-osx cross-compilation #18630

Merged
merged 1 commit into from
Jul 16, 2021
Merged

[openssl] Fix x86-osx -> arm64-osx cross-compilation #18630

merged 1 commit into from
Jul 16, 2021

Conversation

Lucius-Q-User
Copy link
Contributor

Currently attempting to cross-compile arm64-osx version of openssl results in a miscompilation, as the compiler produces an ios binary instead of a macos one.

  • What does your PR fix?

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    x86-osx, arm64-osx No

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

@PhoebeHui PhoebeHui added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Jun 25, 2021
@Lucius-Q-User Lucius-Q-User marked this pull request as ready for review June 29, 2021 11:41
@PhoebeHui
Copy link
Contributor

@Lucius-Q-User, sorry for the delay, could you resolve the conflicts?

@PhoebeHui PhoebeHui added requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. and removed requires:author-response labels Jul 7, 2021
@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Jul 7, 2021
@Lucius-Q-User Lucius-Q-User mentioned this pull request Jul 8, 2021
Closed
@vicroms vicroms merged commit 588b1e6 into microsoft:master Jul 16, 2021
@vicroms
Copy link
Member

vicroms commented Jul 16, 2021

Thanks for the PR!

@Lucius-Q-User Lucius-Q-User deleted the openssl-fix branch July 16, 2021 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhoebeHui PhoebeHui PhoebeHui approved these changes

Assignees

@PhoebeHui PhoebeHui

Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lucius-Q-User @PhoebeHui @vicroms