Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cimg/libgd/libfabric] Update to latest release version #20068

Merged
merged 5 commits into from
Sep 14, 2021

Conversation

PhoebeHui
Copy link
Contributor

@PhoebeHui PhoebeHui commented Sep 9, 2021

Fixes #19870
Fixes #19451
Fixes #19927

libfabric: Update patch to match the source changes.
cimg: Update to latest release.
libgd:

  1. Update exist 3 patches to match the source changes.
  2. Add new patch fix_msvc_build.patch to fix source issue ssize_t used in gdft.c won't compile under MS compiler libgd/libgd#679 and find dependency port webp. This issue has been fixed in Upstream, will be included in future release 2.3.4.

@PhoebeHui PhoebeHui added info:internal This PR or Issue was filed by the vcpkg team. category:port-update The issue is with a library, which is requesting update new revision labels Sep 9, 2021
ports/libgd/portfile.cmake Outdated Show resolved Hide resolved
@PhoebeHui PhoebeHui linked an issue Sep 9, 2021 that may be closed by this pull request
@pierrejoye
Copy link

Good afternoon,

thanks for taking care of libgd here :)

ssize_t is fixed in libgd/libgd and will be in the upcoming 2.3.4. By the way, we do support windows (now with Windows CI up and running so that kind of build issues should not happen anymore), would it be possible to have such patches upstream as well? It would be easier than maintaining async trees on each side?

For the record here, I added the intrinsics header fix (will be in 2.3.4).

I am not sure what are the goals of the Cmake changes tho', happy to apply a PR in libgd/libgd if that helps and I know what they are for :)

@PhoebeHui
Copy link
Contributor Author

@pierrejoye, thanks for your comments, I will submit a PR to Upstream.

@pierrejoye
Copy link

pierrejoye commented Sep 10, 2021 via email

@PhoebeHui
Copy link
Contributor Author

@pierrejoye, yes, the patch would be removed when upgrade it in next release.

@PhoebeHui
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@NancyLi1013 NancyLi1013 added the info:reviewed Pull Request changes follow basic guidelines label Sep 13, 2021
ports/libgd/vcpkg.json Outdated Show resolved Hide resolved
@BillyONeal BillyONeal added requires:author-response and removed info:reviewed Pull Request changes follow basic guidelines labels Sep 13, 2021
Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking for upstream confirmation that they actually do semver.

@PhoebeHui PhoebeHui added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Sep 14, 2021
@BillyONeal BillyONeal merged commit a35e237 into microsoft:master Sep 14, 2021
@BillyONeal
Copy link
Member

Thanks for the update!

Jimmy-Hu added a commit to Jimmy-Hu/vcpkg that referenced this pull request Sep 14, 2021
[cimg/libgd/libfabric] Update to latest release version (microsoft#20068)
@PhoebeHui PhoebeHui deleted the dev/Phoebe/manyports_5 branch September 15, 2021 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
4 participants