-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cimg/libgd/libfabric] Update to latest release version #20068
[cimg/libgd/libfabric] Update to latest release version #20068
Conversation
Good afternoon, thanks for taking care of libgd here :) ssize_t is fixed in libgd/libgd and will be in the upcoming 2.3.4. By the way, we do support windows (now with Windows CI up and running so that kind of build issues should not happen anymore), would it be possible to have such patches upstream as well? It would be easier than maintaining async trees on each side? For the record here, I added the intrinsics header fix (will be in 2.3.4). I am not sure what are the goals of the Cmake changes tho', happy to apply a PR in libgd/libgd if that helps and I know what they are for :) |
@pierrejoye, thanks for your comments, I will submit a PR to Upstream. |
thanks @phoebe :)
I think the last patch is fixed already (unistd.h), I see now the cmake
change and it makes sense, I am applying it now too.
…On Fri, Sep 10, 2021, 2:09 PM Phoebe ***@***.***> wrote:
@pierrejoye <https://github.com/pierrejoye>, thanks for your comments, I
will submit a PR to Upstream.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#20068 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACE6KGVYCYZ4XUIXWJCS3LUBGVI3ANCNFSM5DWZEC2Q>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
@pierrejoye, yes, the patch would be removed when upgrade it in next release. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking for upstream confirmation that they actually do semver.
Thanks for the update! |
[cimg/libgd/libfabric] Update to latest release version (microsoft#20068)
Fixes #19870
Fixes #19451
Fixes #19927
libfabric: Update patch to match the source changes.
cimg: Update to latest release.
libgd: