-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tomlplusplus] Update to 2.5.0 #20164
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@qudix, thanks for the PR!
Could you address the review suggestion?
I'm not sure what's wrong with CI, seems unrelated? |
The CI failed with the following failure, It looks relate to #20140 @BillyONeal, do you know how to find the 2 unexpected failures port? eg: x86-windows:
31 cascaded failures in CI testing:
|
|
It was just a count lock, not a per-port lock. We backed out the check entirely. |
Thanks for your update! |
[tomlplusplus] Update to 2.5.0 (microsoft#20164)
Describe the pull request
What does your PR fix?
Updates tomlplusplus to 2.5.0
Which triplets are supported/not supported? Have you updated the CI baseline?
Just an update
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?Yes