Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tomlplusplus] Update to 2.5.0 #20164

Merged
merged 5 commits into from
Sep 16, 2021
Merged

Conversation

qudix
Copy link
Contributor

@qudix qudix commented Sep 15, 2021

Describe the pull request

  • What does your PR fix?

    Updates tomlplusplus to 2.5.0

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    Just an update

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

@ghost
Copy link

ghost commented Sep 15, 2021

CLA assistant check
All CLA requirements met.

@PhoebeHui PhoebeHui self-assigned this Sep 15, 2021
@PhoebeHui PhoebeHui added the category:port-update The issue is with a library, which is requesting update new revision label Sep 15, 2021
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qudix, thanks for the PR!

Could you address the review suggestion?

@qudix
Copy link
Contributor Author

qudix commented Sep 15, 2021

I'm not sure what's wrong with CI, seems unrelated?

@PhoebeHui
Copy link
Contributor

PhoebeHui commented Sep 15, 2021

The CI failed with the following failure, It looks relate to #20140

@BillyONeal, do you know how to find the 2 unexpected failures port?

eg: x86-windows:

Expected 28 cascaded failures, but there were 31 cascaded failures.
##[error]vcpkg ci failed
At C:\a\1\s\scripts\azure-pipelines\test-modified-ports.ps1:174 char:5
+     throw "vcpkg ci failed"
+     ~~~~~~~~~~~~~~~~~~~~~~~
+ CategoryInfo          : OperationStopped: (vcpkg ci failed:String) [], RuntimeException
+ FullyQualifiedErrorId : vcpkg ci failed
##[error]PowerShell exited with code '1'.

31 cascaded failures in CI testing:

Port Status Hash
flint:x86-windows: cascade: bd8f983353d6387178cd72931ca217ce31ea0e2d49e3795691f505f935d4de46
arb:x86-windows: cascade: dfff33230bd048ba77c2fb2d09bb72453f83728e58639c39835510419908a2cb
aws-c-event-stream:x86-windows: cascade: b847e1578c25a53786e5385149b7c71fdaa89ad2b5adfa4e059dc452eb1da2ca
aws-crt-cpp:x86-windows: cascade: d61a830a098d5b55c0640132d80fb686e1ca21a7808cb1f913da9ac98dd94001
aws-sdk-cpp:x86-windows: cascade: 68a9d8e05e136295f6f19bdee379c0ab9b06c7ec6fd87d510070bd88a573fe34
basisu:x86-windows: cascade: 2f2c57f2cda5d868ec51255d8d5e2a5440f31576596470c2fb0189990b4090e5
crashrpt:x86-windows: cascade: ee53b5751b9db0e521d6abf2895f5b8211507cf1ae8bc14cf9e0c79ed512fc48
dbow3:x86-windows: cascade: b9ebdfde6843f8620c9d4acf2bf2831c507f212662cc6a389160ac1273788de7
fizz:x86-windows: cascade: e3ca050c786fc166e14dba6915f855ac5d1eae5f994904750b6f0b92d2c421f0
wangle:x86-windows: cascade: 1d92a5dab9cb44e72011c321b1b675cb7b4ad2f1ab1ad25977e1ce7129d56312
functions-framework-cpp:x86-windows: cascade: c22abc4e83790ee7f93a2261adf20a34091d679ef9b6b7375deb9d7fb597ba4b
grpc:x86-windows: cascade: 7819e9201aab5c701b13b65e9d4d55cb9cfb66039cfcad276ade6e0a1d6ef840
google-cloud-cpp:x86-windows: cascade: f397727a818f69cf101be62833066efc827e508ff4271682a17020bf4748b4f2
google-cloud-cpp-common:x86-windows: cascade: f093884e7c10e960d48045915d3b4c0409e59574274e4d6ad8fdc19407be1821
google-cloud-cpp-spanner:x86-windows: cascade: fa49d88422b84b681147486f5a4a6f978f33774a6c84b4db698b27555d1542a8
googleapis:x86-windows: cascade: 2b32d7e4a7ffeaab327dfc5ef13f0e34185ff4c99a53eb464d482b8f0427a27b
gstreamer:x86-windows: cascade: 04df8852e89dc333bc578076f21725007ea1932803a4385fceb3e0d6a6cac625
libodb-mysql:x86-windows: cascade: c9938cdd43f079c3cdff863abf0f463ecc394fe8ec23327c24f1ac024510a64c
libtins:x86-windows: cascade: cd2778ea12c0e047afe55adf75d56f698eeb4966c3d3f57e34379f9ad94436d8
nmap:x86-windows: cascade: af06b8102e78100c3069e1076810848ef7a99cbb35055009c58877150a46deee
oatpp-libressl:x86-windows: cascade: 7c031f94bfd8683360312c954a2fe656a8cdcd8286b951c1364cda48c2f49628
offscale-libetcd-cpp:x86-windows: cascade: 63118cbceb62a8ea13e1d237f205a5a1d29d794ae6caa382e2220054ac039aa7
parquet:x86-windows: cascade: 4ec4b6a0a5fd433717961342e96f307e8cf90356f0925cdf2e6865d5397aaca4
pbc:x86-windows: cascade: 952a3b277857314b7d5095d4b1b4fbeaa0845d7e8795d5fe9dc456a7e7eaeb93
pcapplusplus:x86-windows: cascade: 4d96d984794573533d6b7b50e580321fa068bc1486e26e523d4eafe5ebbf8396
rsocket:x86-windows: cascade: 3a06724d8372a5827802a00886a9e4ce1bc0dde3b00c01fc445cb497e66109b2
soem:x86-windows: cascade: 712447b79ee60ebf995c9a8674c71c6eda54f73db4e9263d589d5dd3d728c003
sqlpp11-connector-mysql:x86-windows: cascade: 18307c324c7bca32af33cb1914cc1f288d38c9528add382280578765da129536
volk:x86-windows: cascade: 06b90dfb2f539451d52e33105ef031687e18c16d34240066e0792a3456a7cfd7
vulkan-hpp:x86-windows: cascade: b19c4e682ea76126770da2dfd236bea00c33d80e1109314c882e04ffd6211b36
wxchartdir:x86-windows: cascade: 738160718456eb7de039ed7cbfb95246abf549af91bce0bce2440feca0b2e672

@PhoebeHui
Copy link
Contributor

x86-windows:                   Expected 28 cascaded failures, but there were 31 cascaded failures.
x64-windows:                   Expected 21 cascaded failures, but there were 24 cascaded failures.
x64-windows-static:            Expected 59 cascaded failures, but there were 62 cascaded failures.
x64-windows-static-md:         Expected 53 cascaded failures, but there were 56 cascaded failures.
x64-uwp:                       Expected 345 cascaded failures, but there were 342 cascaded failures.
arm64-windows:                 Expected 228 cascaded failures, but there were 226 cascaded failures.
arm-uwp:                       Expected 345 cascaded failures, but there were 343 cascaded failures.
x64-osx:                       Pass
x64-linux:                     Pass

@BillyONeal
Copy link
Member

@BillyONeal, do you know how to find the 2 unexpected failures port?

It was just a count lock, not a per-port lock. We backed out the check entirely.

@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Sep 16, 2021
@BillyONeal BillyONeal merged commit 3a06c2e into microsoft:master Sep 16, 2021
@BillyONeal
Copy link
Member

Thanks for your update!

Jimmy-Hu added a commit to Jimmy-Hu/vcpkg that referenced this pull request Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants