[libssh2] Update to 1.10.0

[chausner]

Describe the pull request

• What does your PR fix?

  Updates libssh2 to 1.10.0

• Which triplets are supported/not supported? Have you updated the CI baseline?

  As before, Yes

• Does your PR follow the maintainer guide?

  Yes

• If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

  Yes

[github-actions]

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

• ports/libssh2/portfile.cmake

[chausner]

Closing since there is already an open PR: #20067

[JonLiu1993]

@chausner, can you continue to update libssh2 to 1.10.0? I reverted the changes to libssh2, because some fixes are unreasonable, if you can continue to open this pr I will be very happy .

[github-actions]

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

• ports/libssh2/portfile.cmake

[github-actions]

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

• ports/libssh2/portfile.cmake

[chausner]

@JonLiu1993 Sure, I reopened the MR and fixed some remaining issues.

One thing I am not sure about is vcpkg build validation errors related to the DLL not having any exports and no import library getting built when I migrated to the new way of including CMake commands (vcpkg-cmake and vcpkg-cmake-config dependencies). Only after reverting this change (0fe7011) it works again.

So it seems vcpkg_configure_cmake is not equivalent to vcpkg_cmake_configure? Do you know what needs to be changed to make it work with the new commands?

[JonLiu1993]

@JonLiu1993 Sure, I reopened the MR and fixed some remaining issues.

One thing I am not sure about is vcpkg build validation errors related to the DLL not having any exports and no import library getting built when I migrated to the new way of including CMake commands (vcpkg-cmake and vcpkg-cmake-config dependencies). Only after reverting this change (0fe7011) it works again.

So it seems vcpkg_configure_cmake is not equivalent to vcpkg_cmake_configure? Do you know what needs to be changed to make it work with the new commands?

I read your modification and it is no problem. However, there are some BUGs in the use of new cmake functions. Not all ports are suitable for using the new cmake functions.

[github-actions]

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

• ports/libssh2/portfile.cmake

[github-actions]

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

• ports/libssh2/portfile.cmake

[BillyONeal]

Thanks for the version update!