Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg baseline][gstreamer] Disable feature pango #20737

Merged
merged 2 commits into from
Oct 16, 2021

Conversation

JackBoosY
Copy link
Contributor

Fix baseline issue:

ninja: error: 'D:/installed/x86-windows/debug/lib/harfbuzzlibd.lib', needed by 'subprojects/gst-plugins-base/ext/pango/gstpango.dll', missing and no known rule to make it

This is because gstreamer automatically detects the dependency pango and active the feature pango, and pango relies on the internal harfbuzz.

gst-plugins-base| Run-time dependency pangocairo found: YES 1.48.4

Disable this feature now.

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Oct 14, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 28af86cc15b53c09de6c0457e0ac737795e497e2 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index 48ed547..688ff9d 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -2558,7 +2558,7 @@
     },
     "gstreamer": {
       "baseline": "1.19.2",
-      "port-version": 0
+      "port-version": 1
     },
     "gtest": {
       "baseline": "1.11.0",
diff --git a/versions/g-/gstreamer.json b/versions/g-/gstreamer.json
index d936260..c490680 100644
--- a/versions/g-/gstreamer.json
+++ b/versions/g-/gstreamer.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "9e1e058b933a63ff71eeaa2a7a59fa713d0ba51b",
+      "version": "1.19.2",
+      "port-version": 1
+    },
     {
       "git-tree": "25482bf1d9dd85257c13e394b45745f77a29bf51",
       "version": "1.19.2",

@JackBoosY
Copy link
Contributor Author

JackBoosY commented Oct 14, 2021

Will rerun this PR after #20730 merge.

@JackBoosY JackBoosY added the depends:different-pr This PR or Issue depends on a PR which has been filed label Oct 14, 2021
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BillyONeal
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@BillyONeal BillyONeal force-pushed the dev/jack/fix-baseline-20211014 branch from 38f04cc to 1f49dd5 Compare October 15, 2021 00:16
@JackBoosY JackBoosY added info:reviewed Pull Request changes follow basic guidelines and removed depends:different-pr This PR or Issue depends on a PR which has been filed labels Oct 15, 2021
@vicroms vicroms merged commit 010637b into microsoft:master Oct 16, 2021
@vicroms
Copy link
Member

vicroms commented Oct 16, 2021

Thanks @JackBoosY!

@JackBoosY JackBoosY deleted the dev/jack/fix-baseline-20211014 branch October 18, 2021 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants