Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aws-sdk-cpp] Fix the path in the export cmake config #21240

Merged
merged 2 commits into from
Nov 9, 2021

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Nov 7, 2021

  • What does your PR fix?

    Fixes the AWSSDK_DEFAULT_ROOT_DIR in the export cmake config so that `find_package(AWSSDK) can actually suceed.
    (Discovered while, and needed for, testing the netcdf update, [netcdf-c] Update to 4.8.1, revise features #21239.)
    Intentionally no other changes.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    unchanged, no.

  • Does your PR follow the maintainer guide?

    yes.

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    yes.

@NancyLi1013 NancyLi1013 added the category:port-bug The issue is with a library, which is something the port should already support label Nov 8, 2021
@NancyLi1013 NancyLi1013 added the info:reviewed Pull Request changes follow basic guidelines label Nov 8, 2021
@NancyLi1013
Copy link
Contributor

LGTM, thanks for the fixes. @dg0yt

@NancyLi1013 NancyLi1013 changed the title [aws-sdk-cpp] [aws-sdk-cpp] Fix the path in the export cmake config Nov 8, 2021
@dan-shaw dan-shaw merged commit 09ec363 into microsoft:master Nov 9, 2021
@dg0yt dg0yt deleted the aws-sdk-cpp branch November 13, 2021 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants