Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libudns] use supports expression #21448

Merged
merged 1 commit into from
Nov 17, 2021
Merged

[libudns] use supports expression #21448

merged 1 commit into from
Nov 17, 2021

Conversation

autoantwort
Copy link
Contributor

No description provided.

@JackBoosY JackBoosY added category:code-cleanup This PR cleans up code, without fixing any existing bugs nor adding any features. category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist labels Nov 16, 2021
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Nov 16, 2021
@cenit
Copy link
Contributor

cenit commented Nov 16, 2021

isn’t it better to write supports: linux?

@JackBoosY
Copy link
Contributor

isn’t it better to write supports: linux?

We'd better use black list instead of white list. I think.

@vicroms vicroms merged commit 6e869fd into microsoft:master Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackBoosY JackBoosY JackBoosY approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@JackBoosY JackBoosY

Labels
category:code-cleanup This PR cleans up code, without fixing any existing bugs nor adding any features. category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@autoantwort @cenit @JackBoosY @vicroms