Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg baseline][python3] Fix race during parallel install #21734

Merged
merged 2 commits into from
Nov 29, 2021

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Nov 28, 2021

@JackBoosY JackBoosY added the category:port-bug The issue is with a library, which is something the port should already support label Nov 29, 2021
@JackBoosY JackBoosY changed the title [python3] Fix race during parallel install [vcpkg baseline][python3] Fix race during parallel install Nov 29, 2021
@JackBoosY
Copy link
Contributor

LGTM, thanks for your fix!

@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Nov 29, 2021
@JackBoosY
Copy link
Contributor

Ping @BillyONeal for merge this PR first.

@BillyONeal BillyONeal merged commit a515872 into microsoft:master Nov 29, 2021
@BillyONeal
Copy link
Member

Thanks for the fix!

@dg0yt dg0yt deleted the python3 branch November 29, 2021 18:18
BillyONeal added a commit to ras0219-msft/vcpkg that referenced this pull request Feb 4, 2022
…icrosoft#21734)"

This reverts commit a515872.

# Conflicts:
#	ports/python3/vcpkg.json
#	versions/baseline.json
#	versions/p-/python3.json
BillyONeal added a commit that referenced this pull request Feb 4, 2022
…nditions (#22902)

* [python3][python2] Use mkdir -p to create directories to avoid race conditions

* Revert "[vcpkg baseline][python3] Fix race during parallel install (#21734)"

This reverts commit a515872.

# Conflicts:
#	ports/python3/vcpkg.json
#	versions/baseline.json
#	versions/p-/python3.json

Co-authored-by: Billy Robert O'Neal III <bion@microsoft.com>
@ras0219-msft
Copy link
Contributor

ras0219-msft commented Feb 10, 2022

(as noted by @dg0yt) In light of #22902 it might be reasonable to remove this patch, though a big question would be how much time does it save vs the effort of potentially re-introducing other races.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants