Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[openImageIO] update to 2.3.10.1 #22316

Merged
merged 8 commits into from
Jan 5, 2022

Conversation

FrankXie05
Copy link
Contributor

Fix #22263
[openImageIO] update to 2.3.10.1
All features have been tested successfullly in the following triplet:

  • x64-windows
  • x64-windows-static
  • x86-windows

@FrankXie05 FrankXie05 added info:internal This PR or Issue was filed by the vcpkg team. category:port-update The issue is with a library, which is requesting update new revision labels Jan 4, 2022
@FrankXie05 FrankXie05 marked this pull request as ready for review January 4, 2022 03:20
@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Jan 4, 2022
@strega-nil-ms
Copy link
Contributor

LGTM, thanks @FrankXie05 !

@strega-nil-ms strega-nil-ms merged commit b934807 into microsoft:master Jan 5, 2022
@DougRogers
Copy link

DougRogers commented Jan 5, 2022

I have tried vcpkg update and vcpkg upgrade, but that does not pull this update. Is there something else I need to do to get this?

@JonLiu1993
Copy link
Member

I have tried vcpkg update and vcpkg upgrade, but that does not pull this update. Is there something else I need to do to get this?

@DougRogers ,You can run command ".\bootstrap-vcpkg.bat" and "git pull " try again

@dg0yt
Copy link
Contributor

dg0yt commented Jan 6, 2022

@DougRogers ,You can run command ".\bootstrap-vcpkg.bat" and "git pull " try again

... but git pull first!

@DougRogers
Copy link

I get this error:

C:\Users\Roger\source\repos\vcpkg>git pull
fatal: not a git repository (or any of the parent directories): .git

@DougRogers
Copy link

For my issue, I had not done a git clone to get the project but used the .zip.

@FrankXie05
Copy link
Contributor Author

@DougRogers Make sure you download the latest vcpkg library or you can try to clone the vcpkg library and use the following command to achieve real-time update :

@DougRogers
Copy link

DougRogers commented Jan 14, 2022

Thank you. I was able to pull properly. Unfortunately, I am getting link errors with the new version.


1>   Creating library C:\Users\Roger\source\repos\Projects\ImageViewers\Tinta\x64\Debug\QtOIIOPlugin.lib and object C:\Users\Roger\source\repos\Projects\ImageViewers\Tinta\x64\Debug\QtOIIOPlugin.exp
1>QtOIIOHandler.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) public: __cdecl OpenImageIO_v2_3::TypeDesc::TypeDesc(enum OpenImageIO_v2_3::TypeDesc::BASETYPE,enum OpenImageIO_v2_3::TypeDesc::AGGREGATE,enum OpenImageIO_v2_3::TypeDesc::VECSEMANTICS,int)" (__imp_??0TypeDesc@OpenImageIO_v2_3@@QEAA@W4BASETYPE@01@W4AGGREGATE@01@W4VECSEMANTICS@01@H@Z) referenced in function "public: virtual bool __cdecl QtOIIOHandler::read(class QImage *)" (?read@QtOIIOHandler@@UEAA_NPEAVQImage@@@Z)
1>QtOIIOHandler.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) public: __cdecl OpenImageIO_v2_3::TypeDesc::TypeDesc(struct OpenImageIO_v2_3::TypeDesc const &)" (__imp_??0TypeDesc@OpenImageIO_v2_3@@QEAA@AEBU01@@Z) referenced in function "public: virtual bool __cdecl QtOIIOHandler::read(class QImage *)" (?read@QtOIIOHandler@@UEAA_NPEAVQImage@@@Z)
1>QtOIIOPlugin.obj : error LNK2001: unresolved external symbol "__declspec(dllimport) public: __cdecl OpenImageIO_v2_3::TypeDesc::TypeDesc(struct OpenImageIO_v2_3::TypeDesc const &)" (__imp_??0TypeDesc@OpenImageIO_v2_3@@QEAA@AEBU01@@Z)
1>QtOIIOHandler.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) public: char const * __cdecl OpenImageIO_v2_3::TypeDesc::c_str(void)const " (__imp_?c_str@TypeDesc@OpenImageIO_v2_3@@QEBAPEBDXZ) referenced in function "public: virtual bool __cdecl QtOIIOHandler::read(class QImage *)" (?read@QtOIIOHandler@@UEAA_NPEAVQImage@@@Z)
1>QtOIIOHandler.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) public: bool __cdecl OpenImageIO_v2_3::TypeDesc::is_array(void)const " (__imp_?is_array@TypeDesc@OpenImageIO_v2_3@@QEBA_NXZ) referenced in function "bool __cdecl OpenImageIO_v2_3::operator!=(struct OpenImageIO_v2_3::TypeDesc const &,enum OpenImageIO_v2_3::TypeDesc::BASETYPE)" (??9OpenImageIO_v2_3@@YA_NAEBUTypeDesc@0@W4BASETYPE@10@@Z)
1>QtOIIOPlugin.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) public: __cdecl OpenImageIO_v2_3::ustring::ustring(void)" (__imp_??0ustring@OpenImageIO_v2_3@@QEAA@XZ) referenced in function "bool __cdecl OpenImageIO_v2_3::getattribute(class OpenImageIO_v2_3::string_view,class std::basic_string<char,struct 

std::char_traits<char>,class std::allocator<char> > &)" (?getattribute@OpenImageIO_v2_3@@YA_NVstring_view@1@AEAV?
$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@Z)
1>QtOIIOPlugin.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) public: __cdecl OpenImageIO_v2_3::ustring::~ustring(void)" (__imp_??1ustring@OpenImageIO_v2_3@@QEAA@XZ) referenced in function "bool __cdecl OpenImageIO_v2_3::getattribute(class OpenImageIO_v2_3::string_view,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > &)" (?getattribute@OpenImageIO_v2_3@@YA_NVstring_view@1@AEAV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@Z)
1>QtOIIOPlugin.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) public: class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const & __cdecl OpenImageIO_v2_3::ustring::string(void)const " (__imp_?string@ustring@OpenImageIO_v2_3@@QEBAAEBV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@XZ) referenced in function "bool __cdecl OpenImageIO_v2_3::getattribute(class OpenImageIO_v2_3::string_view,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > &)" (?getattribute@OpenImageIO_v2_3@@YA_NVstring_view@1@AEAV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@Z)
1>C:\Users\Roger\source\repos\Projects\ImageViewers\Tinta\x64\Debug\QtOIIOPlugin.dll : fatal error LNK1120: 7 unresolved externals

@FrankXie05
Copy link
Contributor Author

@DougRogers Could you please resubmit a new issue and we'll fix it. :)

@DougRogers
Copy link

Certainly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[OpenImageIO] update to 2.3.10.1
5 participants