-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[qtbase] Make feature pcre2 to hard dependency when install static library #22584
[qtbase] Make feature pcre2 to hard dependency when install static library #22584
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one portfile where deprecated functions are used.
If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake
-> vcpkg_cmake_install
(from port vcpkg-cmake
)
vcpkg_build_cmake
-> vcpkg_cmake_build
(from port vcpkg-cmake
)
vcpkg_configure_cmake
-> vcpkg_cmake_configure
(Please remove the option PREFER_NINJA
) (from port vcpkg-cmake
)
vcpkg_fixup_cmake_targets
-> vcpkg_cmake_config_fixup
(from port vcpkg-cmake-config
)
In the ports that use the new function, you have to add the corresponding dependencies:
{
"name": "vcpkg-cmake",
"host": true
},
{
"name": "vcpkg-cmake-config",
"host": true
}
The following files are affected:
ports/qtbase/portfile.cmake
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout bba8794b82a0f44b8709f294850a2c8e96b61415 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/q-/qtbase.json b/versions/q-/qtbase.json
index 503e244..b938dcb 100644
--- a/versions/q-/qtbase.json
+++ b/versions/q-/qtbase.json
@@ -1,7 +1,7 @@
{
"versions": [
{
- "git-tree": "97f29b7c4139a014126e6da5ffdb61f1f04411dc",
+ "git-tree": "e9fa18e04e930f9ada49aac4dca2e9fe4958b89a",
"version-semver": "6.2.2",
"port-version": 3
},
This LGTM, thanks! |
Fixes #22482
When install
qtbase[core,gui,doubleconversion]:x64-windows-static
,qtbase
will build failed with the following error:This need install
qtbase[pcre2]
, add fatal error to remind install featurepcre2
.