[colmap] Upgrade to version 3.7 #22805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
All manifest files must be formatted
./vcpkg format-manifest ports/*/vcpkg.json
Diff
diff --git a/ports/colmap/vcpkg.json b/ports/colmap/vcpkg.json
index 6bad931..b8efe32 100644
--- a/ports/colmap/vcpkg.json
+++ b/ports/colmap/vcpkg.json
@@ -1,7 +1,6 @@
{
"name": "colmap",
"version-string": "3.7",
- "port-version": 0,
"description": "COLMAP is a general-purpose Structure-from-Motion (SfM) and Multi-View Stereo (MVS) pipeline with a graphical and command-line interface. It offers a wide range of features for reconstruction of ordered and unordered image collections. The software is licensed under the new BSD license.",
"homepage": "https://colmap.github.io/",
"license": "BSD-3-Clause",After committing all other changes, the version database must be updated
git add -u && git commit
git checkout f1dfd6581c52a1e4ead36571d94e7ce8d2682570 -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/baseline.json b/versions/baseline.json
index 481a0f4..2265ff3 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -1461,8 +1461,8 @@
"port-version": 6
},
"colmap": {
- "baseline": "3.6",
- "port-version": 2
+ "baseline": "3.7",
+ "port-version": 0
},
"comms": {
"baseline": "3.4.0",
diff --git a/versions/c-/colmap.json b/versions/c-/colmap.json
index 118e563..b29b67c 100644
--- a/versions/c-/colmap.json
+++ b/versions/c-/colmap.json
@@ -1,5 +1,10 @@
{
"versions": [
+ {
+ "git-tree": "81329023ad5f9b2bd27554d2d8a97f8e63aef708",
+ "version-string": "3.7",
+ "port-version": 0
+ },
{
"git-tree": "7d3a2a8f71b464856f91f3b8b7e2362ec27d6487",
"version-string": "3.6",
|
Thanks for the update! |
|
This changes has regression: I confirmed the sub target include_directories(
.
)
file(GLOB GRACLUS_HEADER_FILES "metisLib/*.h")
file(GLOB GRACLUS_SOURCE_FILES "metisLib/*.c")
COLMAP_ADD_STATIC_LIBRARY(graclus
${GRACLUS_HEADER_FILES}
${GRACLUS_SOURCE_FILES}
multilevelLib/wkkm.c
multilevelLib/mlkkm.c
) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.