Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[opengl] install pkgconfig files for windows #23536

Merged
merged 2 commits into from
Mar 15, 2022
Merged

Conversation

maz-1
Copy link
Contributor

@maz-1 maz-1 commented Mar 14, 2022

Describe the pull request

  • What does your PR fix?

    install pkgconfig files for windows

  • Which triplets are supported/not supported? Have you updated the [CI baseline]

    windows. no.

  • Does your PR follow the [maintainer guide]

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/opengl/vcpkg.json

Valid values for the license field can be found in the documentation

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/opengl/vcpkg.json

Valid values for the license field can be found in the documentation

@JonLiu1993 JonLiu1993 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Mar 14, 2022
ports/opengl/vcpkg.json Outdated Show resolved Hide resolved
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

All manifest files must be formatted

./vcpkg format-manifest ports/*/vcpkg.json

Diff
diff --git a/ports/opengl/vcpkg.json b/ports/opengl/vcpkg.json
index 4cfc994..e921d64 100644
--- a/ports/opengl/vcpkg.json
+++ b/ports/opengl/vcpkg.json
@@ -1,6 +1,5 @@
 {
   "name": "opengl",
   "version-date": "2022-03-14",
-  "port-version": 0,
   "description": "Open Graphics Library (OpenGL)[3][4][5] is a cross-language, cross-platform application programming interface (API) for rendering 2D and 3D vector graphics."
 }
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout af2287382b1991dbdcb7e5112d236f3323b9dd7a -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/o-/opengl.json b/versions/o-/opengl.json
index d79a861..f2e28fb 100644
--- a/versions/o-/opengl.json
+++ b/versions/o-/opengl.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "1f17ea91adc8b1b695858d25b396fd3b6544bba6",
+      "git-tree": "6778094e7a9e5027545a46af473d27ce28890c53",
       "version-date": "2022-03-14",
       "port-version": 0
     },

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/opengl/vcpkg.json

Valid values for the license field can be found in the documentation

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/opengl/vcpkg.json

Valid values for the license field can be found in the documentation

@maz-1 maz-1 marked this pull request as ready for review March 14, 2022 17:35
@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Mar 15, 2022
@dan-shaw dan-shaw merged commit 436c860 into microsoft:master Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants