Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fbthrift] Fix incorrect path in FBThriftConfig.cmake #23686

Merged
merged 2 commits into from
Mar 22, 2022
Merged

[fbthrift] Fix incorrect path in FBThriftConfig.cmake #23686

merged 2 commits into from
Mar 22, 2022

Conversation

LilyWangLL
Copy link
Contributor

Fixes #23631
Fix incorrect path in FBThriftConfig.cmake:

set_and_check(FBTHRIFT_CMAKE_DIR "${PACKAGE_PREFIX_DIR}/lib/cmake/fbthrift")
set_and_check(FBTHRIFT_INCLUDE_DIR "${PACKAGE_PREFIX_DIR}/include")
if (WIN32)
  set_and_check(FBTHRIFT_COMPILER "${PACKAGE_PREFIX_DIR}/bin/thrift1.exe")
else()
  set_and_check(FBTHRIFT_COMPILER "${PACKAGE_PREFIX_DIR}/bin/thrift1")
endif()

@LilyWangLL LilyWangLL added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Mar 21, 2022
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Mar 21, 2022
@BillyONeal BillyONeal merged commit e4a0503 into microsoft:master Mar 22, 2022
@BillyONeal
Copy link
Member

Thanks for the fix!

@LilyWangLL LilyWangLL deleted the dev/LilyWang/issue23631 branch May 17, 2022 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackBoosY JackBoosY JackBoosY approved these changes

Assignees

@JackBoosY JackBoosY

Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[fbthrift] incorrect path in FBThriftConfig.cmake
3 participants
@LilyWangLL @BillyONeal @JackBoosY