-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[darknet] update to latest version #23978
[darknet] update to latest version #23978
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one portfile where deprecated functions are used.
If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake
-> vcpkg_cmake_install
(from port vcpkg-cmake
)
vcpkg_build_cmake
-> vcpkg_cmake_build
(from port vcpkg-cmake
)
vcpkg_configure_cmake
-> vcpkg_cmake_configure
(Please remove the option PREFER_NINJA
) (from port vcpkg-cmake
)
vcpkg_fixup_cmake_targets
-> vcpkg_cmake_config_fixup
(from port vcpkg-cmake-config
)
In the ports that use the new function, you have to add the corresponding dependencies:
{
"name": "vcpkg-cmake",
"host": true
},
{
"name": "vcpkg-cmake-config",
"host": true
}
The following files are affected:
ports/darknet/portfile.cmake
You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/darknet/vcpkg.json
Valid values for the license field can be found in the documentation
Can you check if darknet's opencv* dependencies really need the default features of opencv*? |
@cenit ,Thanks for your pr, When I run the comand "./vcpkg install darknet[*]:x64-windows" tested the features locally, It failed :
Then I ran the command "./vcpkg remove opencv4:x64-windows" to remove the opencv4 port and tried the command "./vcpkg install darknet[*]:x64-windows" again, but still got this error |
yes, darknet is one of the very few ports that do not obey to new rules, meaning that there are features mutually exclusive and not additive. |
Tested fearture [cuda,cudnn,full,opencv-base,opencv-cuda] successfully in the x64-windows triplet |
Thanks! |
Which triplets are supported/not supported? Have you updated the CI baseline?
All, Yes
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?Yes