Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[darknet] update to latest version #23978

Merged

Conversation

cenit
Copy link
Contributor

@cenit cenit commented Apr 4, 2022

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    All, Yes

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/darknet/portfile.cmake

You have modified or added at least one vcpkg.json where a "license" field is missing.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/darknet/vcpkg.json

Valid values for the license field can be found in the documentation

@dg0yt
Copy link
Contributor

dg0yt commented Apr 4, 2022

Can you check if darknet's opencv* dependencies really need the default features of opencv*?
ATM darknet[opencv*] prevents opting out from default features of opencv. Cf. #20471 (comment).

@JonLiu1993 JonLiu1993 self-assigned this Apr 6, 2022
@JonLiu1993 JonLiu1993 changed the title update darknet to latest version [darknet ] update to latest version Apr 6, 2022
@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Apr 6, 2022
@JonLiu1993 JonLiu1993 changed the title [darknet ] update to latest version [darknet] update to latest version Apr 6, 2022
@JonLiu1993 JonLiu1993 added the requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function label Apr 6, 2022
@JonLiu1993
Copy link
Member

@cenit ,Thanks for your pr, When I run the comand "./vcpkg install darknet[*]:x64-windows" tested the features locally, It failed :

CMake Error at ports/opencv2/portfile.cmake:6 (message):
  OpenCV 4 is installed, please uninstall and try again:

      vcpkg remove opencv4
Call Stack (most recent call first):
  scripts/ports.cmake:145 (include)


error: building opencv2:x64-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with `git pull` and `.\vcpkg update`.
Then check for known issues at:

Then I ran the command "./vcpkg remove opencv4:x64-windows" to remove the opencv4 port and tried the command "./vcpkg install darknet[*]:x64-windows" again, but still got this error

@cenit
Copy link
Contributor Author

cenit commented Apr 6, 2022

yes, darknet is one of the very few ports that do not obey to new rules, meaning that there are features mutually exclusive and not additive.
In fact, if you use opencv-base, you cannot ask for opencv2-base or opencv3-base, because the opencv version on which they depend are incompatible between themselves

@JonLiu1993
Copy link
Member

Tested fearture [cuda,cudnn,full,opencv-base,opencv-cuda] successfully in the x64-windows triplet

@JonLiu1993 JonLiu1993 removed the requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function label Apr 6, 2022
@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Apr 6, 2022
@strega-nil-ms
Copy link
Contributor

Thanks!

@strega-nil-ms strega-nil-ms merged commit e197055 into microsoft:master Apr 6, 2022
@cenit cenit deleted the dev/cenit/darknet_update_20220404 branch April 7, 2022 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants