Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[argtable3] actually disable examples #23990

Merged
merged 9 commits into from
Apr 6, 2022

Conversation

Thomas1664
Copy link
Contributor

Describe the pull request

  • What does your PR fix?

    Follow up on [argtable3] Disable examples #23655
    The switch to disable examples didn't exist in the version that vcpkg was using. Therefore, I updated the port to its latest commit on master.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    <all / linux, windows, ...>, <Yes/No>

  • Does your PR follow the maintainer guide?

    yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    yes

@JonLiu1993 JonLiu1993 self-assigned this Apr 6, 2022
@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Apr 6, 2022
@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Apr 6, 2022
Copy link
Contributor

@strega-nil-ms strega-nil-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not be switching from version to version-date here.

ports/argtable3/portfile.cmake Outdated Show resolved Hide resolved
ports/argtable3/vcpkg.json Outdated Show resolved Hide resolved
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for argtable3 but no changes to version or port version.
-- Version: 3.2.1#1
-- Old SHA: acbbb26e54e658b8af673a112fb338274275ad6b
-- New SHA: ab61d866e03fa64904b09539d5a9595cffb50dde
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 01d6f6ff1e5332b926099f0c23bda996940ad4e8 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/a-/argtable3.json b/versions/a-/argtable3.json
index 1a47181..73a0032 100644
--- a/versions/a-/argtable3.json
+++ b/versions/a-/argtable3.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "ab61d866e03fa64904b09539d5a9595cffb50dde",
+      "git-tree": "acbbb26e54e658b8af673a112fb338274275ad6b",
       "version": "3.2.1",
       "port-version": 1
     },

@Thomas1664
Copy link
Contributor Author

Sorry, was faster than you

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for argtable3 but no changes to version or port version.
-- Version: 3.2.1#1
-- Old SHA: acbbb26e54e658b8af673a112fb338274275ad6b
-- New SHA: 2ffcb1465df32508b2822a1beb95cf692d9cc718
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 407bc79b391a8e30866c95294babca5b111f6006 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/a-/argtable3.json b/versions/a-/argtable3.json
index 635e900..73a0032 100644
--- a/versions/a-/argtable3.json
+++ b/versions/a-/argtable3.json
@@ -1,10 +1,5 @@
 {
   "versions": [
-    {
-      "git-tree": "2ffcb1465df32508b2822a1beb95cf692d9cc718",
-      "version": "3.2.1",
-      "port-version": 1
-    },
     {
       "git-tree": "acbbb26e54e658b8af673a112fb338274275ad6b",
       "version": "3.2.1",

@strega-nil-ms
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@strega-nil-ms strega-nil-ms merged commit 9029caf into microsoft:master Apr 6, 2022
@Thomas1664 Thomas1664 deleted the argtable3-2 branch April 6, 2022 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants