Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[qtwebengine] Fix VS2022 ICE #24532

Merged
merged 5 commits into from
May 4, 2022

Conversation

Neumann-A
Copy link
Contributor

@Neumann-A Neumann-A commented May 4, 2022

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout b98afc9f1192becb2f447cee485ce36ba111f9f6 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index ddd2324..47f5b31 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -5998,7 +5998,7 @@
     },
     "qtwebengine": {
       "baseline": "6.3.0",
-      "port-version": 0
+      "port-version": 1
     },
     "qtwebsockets": {
       "baseline": "6.3.0",
diff --git a/versions/q-/qtwebengine.json b/versions/q-/qtwebengine.json
index 0e91c3f..1cd0b05 100644
--- a/versions/q-/qtwebengine.json
+++ b/versions/q-/qtwebengine.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "53e94179efade14c89c5071d5c46dc022059e5c9",
+      "version": "6.3.0",
+      "port-version": 1
+    },
     {
       "git-tree": "47cd0b321b5eda832afbb46e58159ca3adb65ce9",
       "version": "6.3.0",

@Neumann-A
Copy link
Contributor Author

@BillyONeal You might want to add this patch also to the chomium-base port to re-enable it?

@Neumann-A Neumann-A marked this pull request as ready for review May 4, 2022 10:31
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for qtwebengine but no changes to version or port version.
-- Version: 6.3.0#1
-- Old SHA: 959e01f5131b57a9949781c73252bcc71142ea8a
-- New SHA: 6562d0a0294290afd20da039ff60602c1f3f4701
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

# We know that C:/buildrees/${PORT} is to long to build Release. Debug works however. Means 24 length is too much but 23 might work.
if(buildtree_length GREATER 22 AND VCPKG_TARGET_IS_WINDOWS)
message(WARNING "Buildtree path '${CURRENT_BUILDTREES_DIR}' is too long.\nConsider passing --x-buildtrees-root=<shortpath> to vcpkg!\nTrying to use '${CURRENT_BUILDTREES_DIR}/../tmp'")
set(CURRENT_BUILDTREES_DIR "${CURRENT_BUILDTREES_DIR}/../tmp") # activly avoid long path issues in CI. -> Means CI will not return logs
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BillyONeal Is there a clever way to make CI return these logs?
https://dev.azure.com/vcpkg/public/_build/results?buildId=71640&view=logs&jobId=7922e5c4-0103-5f8f-ad17-45ce9bb98e80&j=7922e5c4-0103-5f8f-ad17-45ce9bb98e80&t=491b9f02-7edc-5990-cda1-511e95a3768e was successful but the host build seems to fail sometimes in other triplets (at least in the latest CI) run other than x64-windows

@BillyONeal BillyONeal merged commit ea31629 into microsoft:master May 4, 2022
@BillyONeal
Copy link
Member

Thanks for the ICE workaround!

@Neumann-A Neumann-A deleted the ice_qtwebengine_fix branch May 5, 2022 05:05
@LilyWangLL LilyWangLL mentioned this pull request Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Qtwebengine] add security patch
2 participants