-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[opencv4, opencv3, opencv2] Add feature dc1394 #24595
[opencv4, opencv3, opencv2] Add feature dc1394 #24595
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one vcpkg.json where you should check the license
field.
If you feel able to do so, please consider adding a "license" field to the following files:
scripts/test_ports/vcpkg-ci-opencv/vcpkg.json
Valid values for the license field can be found in the documentation
cc @cenit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one vcpkg.json where you should check the license
field.
If you feel able to do so, please consider adding a "license" field to the following files:
scripts/test_ports/vcpkg-ci-opencv/vcpkg.json
Valid values for the license field can be found in the documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you forgot to add the new feature to the opencv metaport
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one vcpkg.json where you should check the license
field.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/opencv/vcpkg.json
scripts/test_ports/vcpkg-ci-opencv/vcpkg.json
Valid values for the license field can be found in the documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one vcpkg.json where you should check the license
field.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/opencv/vcpkg.json
scripts/test_ports/vcpkg-ci-opencv/vcpkg.json
Valid values for the license field can be found in the documentation
vcpkg-ci-opencv:x64-windows: cascade this is NOT GOOD (it is not outside of this PR) @LilyWangLL please verify where you added the dc1394 feature in vcpkg-ci-opencv, maybe you put it in a too-broad scope and made it impossible to build the port wherever the dependency is not supported |
remove dc1394 from here
and put it here maybe vcpkg/scripts/test_ports/vcpkg-ci-opencv/vcpkg.json Lines 29 to 31 in efba743
(or even better, add a new category for !windows, since libdc1394 is supported there and not just on linux) |
afterwards, please verify that vcpkg-ci-opencv is built and tested ON ALL TRIPLETS, none has to be a cascade failure! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
afterwards, please verify that vcpkg-ci-opencv is built and tested ON ALL TRIPLETS, none has to be a cascade failure!
https://dev.azure.com/vcpkg/public/_build/results?buildId=71865&view=results
vcpkg-ci-opencv:x86-windows: cascade: 47a9c08c0fc66276067fbdd181fba8ae740af40fa18277b40a462f86a2021b9e
vcpkg-ci-opencv:x64-windows: cascade: 44957581fa12ed4fb478422e4a391e8cb85b66fd5f2047e6e3531034ff9777e3
vcpkg-ci-opencv:x64-windows-static: cascade: 0043ddbf763e6df8aa7e0fcedeb989372b190ade2df9320dbce8e98f68e68b4a
vcpkg-ci-opencv:x64-windows-static-md: cascade: 0169f30e50896ee3f1b142343b936be80adec51c6fb1992ecb57bcf4e2c68310
vcpkg-ci-opencv:x64-uwp: cascade: e3e8d4f64c4c83db260392b7410c2665fb85dcbdc233052ca8f979ff2c1333f1
(I didn't check all the triplets, I got through 6 and went "something is broken" and moved on.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one vcpkg.json where you should check the license
field.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/opencv/vcpkg.json
scripts/test_ports/vcpkg-ci-opencv/vcpkg.json
Valid values for the license field can be found in the documentation
This is my mistake, I have changed it. Thanks~ |
just by looking at the time spent by each pipeline, i saw that arm64-windows is still a cascade failure what happened? |
@LilyWangLL arm64-windows cascade failure is not your fault. It is another PR that broke it and went unnoticed... |
…LilyWang/PR22648
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one vcpkg.json where you should check the license
field.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/opencv/vcpkg.json
scripts/test_ports/vcpkg-ci-opencv/vcpkg.json
Valid values for the license field can be found in the documentation
Ok, manually validated that vcpkg-ci-opencv was successfully built for every triplet in 0de243c. I've also opened microsoft/vcpkg-tool#579 which will (eventually) enable us to add Thanks for the PR! |
Fixes #21781, Add feature dc1394 for opencv4 and opencv3 and opencv2. Feature dc1394 test pass on Linux.