-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[openssl] Add no-module configure option for static build #24598
Merged
BillyONeal
merged 13 commits into
microsoft:master
from
LilyWangLL:dev/LilyWang/issue24559
May 19, 2022
Merged
[openssl] Add no-module configure option for static build #24598
BillyONeal
merged 13 commits into
microsoft:master
from
LilyWangLL:dev/LilyWang/issue24559
May 19, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LilyWangLL
added
category:port-feature
The issue is with a library, which is requesting new capabilities that didn’t exist
info:internal
This PR or Issue was filed by the vcpkg team.
labels
May 7, 2022
…LilyWang/issue24559 # Conflicts: # ports/openssl/vcpkg.json # versions/baseline.json # versions/o-/openssl.json
This fix is so much needed. Windows needs it too. |
…LilyWang/issue24559 # Conflicts: # ports/openssl/windows/portfile.cmake # versions/o-/openssl.json
JackBoosY
approved these changes
May 18, 2022
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category:port-feature
The issue is with a library, which is requesting new capabilities that didn’t exist
info:internal
This PR or Issue was filed by the vcpkg team.
info:reviewed
Pull Request changes follow basic guidelines
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix?
Fixes [openssl] Static builds should maybe setno-module
configure option #24559, OpenSSL 3.0 deprecated some old algorithms like RC2-40-CBC, which are still in use in some PKCS#12 certificates. Using them need add optionno-module
for static build.