Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[many ports] Fix cmake warnings #24706

Merged
merged 53 commits into from
May 17, 2022

Conversation

Thomas1664
Copy link
Contributor

@Thomas1664 Thomas1664 commented May 13, 2022

Describe the pull request

  • What does your PR fix?

    Fixes cmake warnings like PREFER_NINJA with vcpkg_cmake_configure and alike

This PR enables us to turn warnings on PREFER_NINJA with vcpkg_cmake_configure and warnings on unparsed arguments into errors. It would help to catch common errors like missing # after commit id in vcpkg_from_github or calling vcpkg_cmake_configure with PREFER_NINJA.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout ad06b4e8699074cc1867e8ca154bf7ad3c9a6f34 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index ad36ecd..c2378c3 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -4018,7 +4018,7 @@
     },
     "libsodium": {
       "baseline": "1.0.18",
-      "port-version": 6
+      "port-version": 7
     },
     "libsoundio": {
       "baseline": "2.0.0",
@@ -4258,7 +4258,7 @@
     },
     "llfio": {
       "baseline": "2.0-20220112",
-      "port-version": 0
+      "port-version": 1
     },
     "llgl": {
       "baseline": "2019-08-15",
diff --git a/versions/l-/libsodium.json b/versions/l-/libsodium.json
index 7c623c5..b193c35 100644
--- a/versions/l-/libsodium.json
+++ b/versions/l-/libsodium.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "9ffdf9b217021918c33311af9faa9b4a3086d004",
+      "version": "1.0.18",
+      "port-version": 7
+    },
     {
       "git-tree": "06e21819c9b176b52aa0b9226c3e2bc07ec20a23",
       "version": "1.0.18",
diff --git a/versions/l-/llfio.json b/versions/l-/llfio.json
index f2a4b54..f7910b2 100644
--- a/versions/l-/llfio.json
+++ b/versions/l-/llfio.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "bc96b88ab308808ce26135e75038c4b316d5533c",
+      "version": "2.0-20220112",
+      "port-version": 1
+    },
     {
       "git-tree": "aaacb49264f3175de57367f28c90bd3904d7209f",
       "version-string": "2.0-20220112",

@Thomas1664 Thomas1664 closed this May 13, 2022
@Thomas1664 Thomas1664 reopened this May 13, 2022
@Thomas1664
Copy link
Contributor Author

@BillyONeal Can you please take a look at this vcpkg crash?

Failure to remove_all_inside("D:\buildtrees") due to file "\\?\D:\buildtrees\ffmpeg": The process cannot access the file because it is being used by another process.
##[error]vcpkg clean failed
At C:\a\1\s\scripts\azure-pipelines\test-modified-ports.ps1:132 char:5
+     throw "vcpkg clean failed"

@BillyONeal
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@BillyONeal
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Thomas1664 Thomas1664 marked this pull request as ready for review May 14, 2022 14:00
@Cheney-W Cheney-W added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label May 16, 2022
@Thomas1664 Thomas1664 requested a review from Adela0814 May 16, 2022 17:16
@Cheney-W Cheney-W added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels May 17, 2022
@BillyONeal BillyONeal merged commit d132d12 into microsoft:master May 17, 2022
@BillyONeal
Copy link
Member

Thanks for the fixes! Sorry for the CI runaround.

@Thomas1664 Thomas1664 deleted the fix-cmake-warnings branch May 17, 2022 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants