-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[many ports] Fix cmake warnings #24706
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout ad06b4e8699074cc1867e8ca154bf7ad3c9a6f34 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index ad36ecd..c2378c3 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -4018,7 +4018,7 @@
},
"libsodium": {
"baseline": "1.0.18",
- "port-version": 6
+ "port-version": 7
},
"libsoundio": {
"baseline": "2.0.0",
@@ -4258,7 +4258,7 @@
},
"llfio": {
"baseline": "2.0-20220112",
- "port-version": 0
+ "port-version": 1
},
"llgl": {
"baseline": "2019-08-15",
diff --git a/versions/l-/libsodium.json b/versions/l-/libsodium.json
index 7c623c5..b193c35 100644
--- a/versions/l-/libsodium.json
+++ b/versions/l-/libsodium.json
@@ -1,5 +1,10 @@
{
"versions": [
+ {
+ "git-tree": "9ffdf9b217021918c33311af9faa9b4a3086d004",
+ "version": "1.0.18",
+ "port-version": 7
+ },
{
"git-tree": "06e21819c9b176b52aa0b9226c3e2bc07ec20a23",
"version": "1.0.18",
diff --git a/versions/l-/llfio.json b/versions/l-/llfio.json
index f2a4b54..f7910b2 100644
--- a/versions/l-/llfio.json
+++ b/versions/l-/llfio.json
@@ -1,5 +1,10 @@
{
"versions": [
+ {
+ "git-tree": "bc96b88ab308808ce26135e75038c4b316d5533c",
+ "version": "2.0-20220112",
+ "port-version": 1
+ },
{
"git-tree": "aaacb49264f3175de57367f28c90bd3904d7209f",
"version-string": "2.0-20220112",
@BillyONeal Can you please take a look at this vcpkg crash?
|
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Cheney-W
added
the
category:port-feature
The issue is with a library, which is requesting new capabilities that didn’t exist
label
May 16, 2022
Adela0814
suggested changes
May 16, 2022
Cheney-W
added
info:reviewed
Pull Request changes follow basic guidelines
and removed
requires:author-response
labels
May 17, 2022
Adela0814
approved these changes
May 17, 2022
Thanks for the fixes! Sorry for the CI runaround. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category:port-feature
The issue is with a library, which is requesting new capabilities that didn’t exist
info:reviewed
Pull Request changes follow basic guidelines
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix?
Fixes cmake warnings likePREFER_NINJA
withvcpkg_cmake_configure
and alikeThis PR enables us to turn warnings on
PREFER_NINJA
withvcpkg_cmake_configure
and warnings on unparsed arguments into errors. It would help to catch common errors like missing#
after commit id invcpkg_from_github
or callingvcpkg_cmake_configure
withPREFER_NINJA
.