[gobject-introspection] no absolute paths #24845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
autoantwort
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where you should check the license field.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/gobject-introspection/vcpkg.json
Valid values for the license field can be found in the documentation
JackBoosY
added
the
category:port-bug
JackBoosY
previously approved these changes
May 24, 2022
ras0219-msft
requested changes
May 24, 2022
Comment on lines
+72
to
+73
| string(REPLACE "datadir = \"${CURRENT_PACKAGES_DIR}/share\"" "raise Exception('could not find right path') " _contents "${_contents}") | ||
| string(REPLACE "pylibdir = os.path.join('${CURRENT_PACKAGES_DIR}/lib', 'gobject-introspection')" "raise Exception('could not find right path') " _contents "${_contents}") |
There was a problem hiding this comment.
If we're patching the file anyway, can we include these changes in the patch?
There was a problem hiding this comment.
I tried it, but the file is also executed while building the package and then the hardcoded path is needed.
# Conflicts: # ports/gobject-introspection/portfile.cmake # ports/gobject-introspection/vcpkg.json # versions/baseline.json # versions/g-/gobject-introspection.json
|
What is the state of this PR? |
JackBoosY
added
the
requires:vcpkg-team-review
|
Ping @ras0219-msft for reply. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #20469