Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pybind11] Update to version 2.10.0 #25377

Merged
merged 4 commits into from
Jul 19, 2022
Merged

Conversation

duanqn
Copy link
Contributor

@duanqn duanqn commented Jun 22, 2022

Describe the pull request

Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

github-actions[bot]
github-actions bot previously approved these changes Jun 22, 2022
@duanqn
Copy link
Contributor Author

duanqn commented Jun 22, 2022

See also pybind/pybind11#3891

@FrankXie05 FrankXie05 added the category:port-update The issue is with a library, which is requesting update new revision label Jun 22, 2022
@FrankXie05
Copy link
Contributor

FrankXie05 commented Jun 22, 2022

@duanqn I think we can apply a patch instead of updating to the latest commit. :)

@jktjkt
Copy link

jktjkt commented Jun 28, 2022

@duanqn I think we can apply a patch instead of updating to the latest commit. :)

Upstream has removed support for Python v2, so the patch doesn't backport cleanly. I gave this a try in #25467 anyway, and I would appreciate feedback; I tried to preserve the Python v2.7 codepath unchanged, which leads to a slightly messier diff.

(Note that I am not on Windows, so I'm mostly working via CI here, but I do need pybind11 for my project, and that patch does the trick on the latest MSVC on Github Windows 2022 environment.)

@FrankXie05
Copy link
Contributor

We can note that this patch will be removed in the next update version.

@FrankXie05
Copy link
Contributor

This PR should be closed if #25467 is merged.

@dan-shaw
Copy link
Contributor

dan-shaw commented Jul 2, 2022

@FrankXie05 I think this PR is better than maintaining a new patch.

@FrankXie05
Copy link
Contributor

@dan-shaw Depending on how often upstream releases new versions, I'll ask questions and ask if upstream will release new versions in the near future.(We try to stay in a stable and reliable release version) Just let us wait. :)

@FrankXie05 FrankXie05 added depends:upstream-changes Waiting on a change to the upstream project and removed requires:author-response labels Jul 4, 2022
@FrankXie05
Copy link
Contributor

A new version will be released upstream in about a week , let's wait a bit
pybind/pybind11#4040 (comment)

@FrankXie05
Copy link
Contributor

@duanqn The new version has been released, we can continue this PR. https://github.com/pybind/pybind11/releases/tag/v2.10.0

@FrankXie05 FrankXie05 removed the depends:upstream-changes Waiting on a change to the upstream project label Jul 18, 2022
@duanqn
Copy link
Contributor Author

duanqn commented Jul 19, 2022

@FrankXie05 Ready for review.

@FrankXie05 FrankXie05 changed the title [pybind11] Update to latest commit [pybind11] Update to 2.10.0 Jul 19, 2022
@FrankXie05 FrankXie05 changed the title [pybind11] Update to 2.10.0 [pybind11] Update to version 2.10.0 Jul 19, 2022
@FrankXie05 FrankXie05 added the info:reviewed Pull Request changes follow basic guidelines label Jul 19, 2022
@vicroms vicroms merged commit ebf637b into microsoft:master Jul 19, 2022
@duanqn duanqn deleted the qiduan/pybind11 branch January 11, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pybind11 fails on cmake find_package
5 participants