-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pybind11] Update to version 2.10.0 #25377
Conversation
See also pybind/pybind11#3891 |
@duanqn I think we can apply a patch instead of updating to the latest commit. :) |
Upstream has removed support for Python v2, so the patch doesn't backport cleanly. I gave this a try in #25467 anyway, and I would appreciate feedback; I tried to preserve the Python v2.7 codepath unchanged, which leads to a slightly messier diff. (Note that I am not on Windows, so I'm mostly working via CI here, but I do need pybind11 for my project, and that patch does the trick on the latest MSVC on Github Windows 2022 environment.) |
We can note that this patch will be removed in the next update version. |
This PR should be closed if #25467 is merged. |
@FrankXie05 I think this PR is better than maintaining a new patch. |
@dan-shaw Depending on how often upstream releases new versions, I'll ask questions and ask if upstream will release new versions in the near future.(We try to stay in a stable and reliable release version) Just let us wait. :) |
A new version will be released upstream in about a week , let's wait a bit |
@duanqn The new version has been released, we can continue this PR. https://github.com/pybind/pybind11/releases/tag/v2.10.0 |
@FrankXie05 Ready for review. |
Describe the pull request
What does your PR fix?
Fixes pybind11 fails on cmake find_package #25163
Which triplets are supported/not supported? Have you updated the CI baseline?
Not changed
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?Yes
If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/