Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[secp256k1] Update secp256k1 from 2017 to 2022 #25398

Merged
merged 18 commits into from
Jul 15, 2022

Conversation

R0g3r10LL31t3
Copy link
Contributor

@R0g3r10LL31t3 R0g3r10LL31t3 commented Jun 22, 2022

Update port unnoficial-secp256k1

  • What does your PR fix?

    Fixes #
    Update the commit reference to bitcoin-core/secp256k1 project to 2022, to keep the portability with VCPKG project.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

Linux, Windows

  • CI tested triplets:

    x64-linux
    x64-windows
    x64-windows-static
    x86-windows
    Others, was skipped.

  • Does your PR follow the maintainer guide?

Whithout necessity of maintanance of main VCPGK project

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes, commited!

…ast year.

- Edit CMakeList.txt to target precomputed library.
- Edit libsecp256k1-config.h to undef and define VARS compilation.
- Edit portfile.cmake to download new sources from repository, commit reference 44c2452fd387f7ca604ab42d73746e7d3a44d8a2 (bitcoin-core/secp256k1)
- Edit vcpkg.json to new version portfile
…ast year

>> vcpkg x-add-version secp256k1
- Update secp256k1.json version
- Update baseline.json version
@JonLiu1993 JonLiu1993 self-assigned this Jun 23, 2022
@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Jun 23, 2022
@JonLiu1993 JonLiu1993 changed the title Update secp256k1 from 2017 to 2022, that added Schnorr Signature on last year. [secp256k1 ]Update secp256k1 from 2017 to 2022 Jun 23, 2022
github-actions[bot]
github-actions bot previously approved these changes Jun 23, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/secp256k1/portfile.cmake

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/secp256k1/vcpkg.json

Valid values for the license field can be found in the documentation

Added JonLiu1993 suggestion. Put PREFER_NINJA to secp256k1/portfile.cmake

Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>
Copy link
Contributor Author

@R0g3r10LL31t3 R0g3r10LL31t3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added JonLiu1993 suggestion. Remove PREFER_NINJA to secp256k1/portfile.cmake

Copy link
Contributor Author

@R0g3r10LL31t3 R0g3r10LL31t3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JonLiu1993
This changes makes a regression.
https://github.com/microsoft/vcpkg/pull/25398/checks?check_run_id=7027450457

Regression resolved!
3e6ebcf

Running the command:
vcpkg x-add-version secp256k1
git add versions
git commit -m "Update version database"

R0g3r10LL31t3 and others added 5 commits June 23, 2022 13:18
Added JonLiu1993 suggestion. Put dependencies to secp256k1/vcpkg.json

Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>
>> vcpkg x-add-version secp256k1
>> vcpkg format-manifest ports/secp256k1/vcpkg.json
vcpkg x-add-version secp256k1
github-actions[bot]
github-actions bot previously approved these changes Jun 24, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/secp256k1/portfile.cmake

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/secp256k1/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions[bot]
github-actions bot previously approved these changes Jul 4, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/secp256k1/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions[bot]
github-actions bot previously approved these changes Jul 4, 2022
@JonLiu1993 JonLiu1993 requested a review from JackBoosY July 4, 2022 08:24
ports/secp256k1/libsecp256k1-config.h Outdated Show resolved Hide resolved
@JackBoosY JackBoosY added depends:upstream-changes Waiting on a change to the upstream project and removed depends:upstream-changes Waiting on a change to the upstream project labels Jul 7, 2022
@JackBoosY JackBoosY changed the title [secp256k1 ]Update secp256k1 from 2017 to 2022 [secp256k1] Update secp256k1 from 2017 to 2022 Jul 12, 2022
github-actions[bot]
github-actions bot previously approved these changes Jul 12, 2022
JackBoosY added 2 commits July 12, 2022 03:16
github-actions[bot]
github-actions bot previously approved these changes Jul 12, 2022
@JackBoosY JackBoosY added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Jul 15, 2022
@vicroms vicroms merged commit 1782b7e into microsoft:master Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants