Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libdatachannel] chore(version): updated to 0.17.8 #25522

Merged
merged 10 commits into from
Jul 5, 2022

Conversation

crisboarna
Copy link
Contributor

Describe the pull request
Updating libdatachannel version.

  • What does your PR fix?

It updates libdatachannel to latest version 0.17.7.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

No.

Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

@ghost
Copy link

ghost commented Jul 1, 2022

CLA assistant check
All CLA requirements met.

@FrankXie05 FrankXie05 added the category:port-update The issue is with a library, which is requesting update new revision label Jul 4, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for libdatachannel have changed but the version was not updated
version: 0.17.7
old SHA: a258e145ae1e34d246e847aa943c4dac5a30a6b9
new SHA: 5963c67be27ebb970b3dcea8e80a64abc610896e
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

@FrankXie05
Copy link
Contributor

Please run command ./vcpkg x-add-version libdatachannel --overwrite-version

@crisboarna
Copy link
Contributor Author

Hi @FrankXie05 ,

I have tried running the requested command but I am getting the following output with no changes performed:

./vcpkg x-add-version libdatachannel --overwrite-version
version 0.17.1 is already in .../vcpkg/versions/l-/libdatachannel.json
version 0.17.1 is already in .../vcpkg/versions/baseline.json
No files were updated for libdatachannel

I am running this on the repo as it is in this branch.

@FrankXie05
Copy link
Contributor

Do you mind if I change it?

@crisboarna
Copy link
Contributor Author

Of course ! Please do.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for libdatachannel have changed but the version was not updated
version: 0.17.7
old SHA: a258e145ae1e34d246e847aa943c4dac5a30a6b9
new SHA: 5963c67be27ebb970b3dcea8e80a64abc610896e
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

github-actions[bot]
github-actions bot previously approved these changes Jul 4, 2022
github-actions[bot]
github-actions bot previously approved these changes Jul 4, 2022
@FrankXie05
Copy link
Contributor

@crisboarna I saw that the latest version 0.17.8 was released upstream, so I updated directly to version 0.17.8. :)
https://github.com/paullouisageneau/libdatachannel/releases/tag/v0.17.8

@FrankXie05 FrankXie05 changed the title [libdatachannel] chore(version): updated to 0.17.7 [libdatachannel] chore(version): updated to 0.17.8 Jul 4, 2022
@FrankXie05
Copy link
Contributor

@crisboarna Regarding the update to port libjuice in the upstream issue I will submit a new PR to resolve
paullouisageneau/libdatachannel#663 (comment)

@FrankXie05 FrankXie05 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Jul 4, 2022
@crisboarna
Copy link
Contributor Author

Thank you very much for the assistance !

@crisboarna
Copy link
Contributor Author

Hi @FrankXie05 , I tried adding libjuice update in #25552 but seems like I ran into the same issue with version command not doing anything ? What is the missing step ?

@BillyONeal BillyONeal merged commit 578406c into microsoft:master Jul 5, 2022
@BillyONeal
Copy link
Member

Thanks :)

@BillyONeal
Copy link
Member

Hi @FrankXie05 , I tried adding libjuice update in #25552 but seems like I ran into the same issue with version command not doing anything ? What is the missing step ?

Most likely your changes weren't committed yet

@FrankXie05
Copy link
Contributor

From the results it looks like applying the changes I requested, I'll keep an eye on it.

@crisboarna crisboarna deleted the feat/libdatachannel-bump branch August 3, 2022 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants