-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[libdatachannel] chore(version): updated to 0.17.8 #25522
[libdatachannel] chore(version): updated to 0.17.8 #25522
Conversation
229931d
to
3ae5ba3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
error: checked-in files for libdatachannel have changed but the version was not updated
version: 0.17.7
old SHA: a258e145ae1e34d246e847aa943c4dac5a30a6b9
new SHA: 5963c67be27ebb970b3dcea8e80a64abc610896e
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
Please run command |
Hi @FrankXie05 , I have tried running the requested command but I am getting the following output with no changes performed:
I am running this on the repo as it is in this branch. |
Do you mind if I change it? |
Of course ! Please do. |
…/libdatachannel-bump
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
error: checked-in files for libdatachannel have changed but the version was not updated
version: 0.17.7
old SHA: a258e145ae1e34d246e847aa943c4dac5a30a6b9
new SHA: 5963c67be27ebb970b3dcea8e80a64abc610896e
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
@crisboarna I saw that the latest version 0.17.8 was released upstream, so I updated directly to version 0.17.8. :) |
@crisboarna Regarding the update to port |
Thank you very much for the assistance ! |
Hi @FrankXie05 , I tried adding |
Thanks :) |
Most likely your changes weren't committed yet |
From the results it looks like applying the changes I requested, I'll keep an eye on it. |
Describe the pull request
Updating libdatachannel version.
What does your PR fix?
It updates libdatachannel to latest version 0.17.7.
Which triplets are supported/not supported? Have you updated the CI baseline?
No.
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?Yes