Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gamedev-framework] Update to v1.0.0 #25842

Merged
merged 11 commits into from
Jul 20, 2022
Merged

[gamedev-framework] Update to v1.0.0 #25842

merged 11 commits into from
Jul 20, 2022

Conversation

ahugeat
Copy link
Contributor

@ahugeat ahugeat commented Jul 18, 2022

Update gamedev-framework to the latest version v1.0.0

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    linux, windows, Yes
    arm, No

  • Does your PR follow the maintainer guide?

    Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout de176433e9a8769eed0e43d61758f4cdc1dc6e20 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index 471b840..3ab9aec 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -2445,8 +2445,8 @@
       "port-version": 6
     },
     "gamedev-framework": {
-      "baseline": "0.20.0",
-      "port-version": 2
+      "baseline": "1.0.0",
+      "port-version": 1
     },
     "gamenetworkingsockets": {
       "baseline": "1.4.1",
diff --git a/versions/g-/gamedev-framework.json b/versions/g-/gamedev-framework.json
index 13f0401..2107612 100644
--- a/versions/g-/gamedev-framework.json
+++ b/versions/g-/gamedev-framework.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "3e567182a4df1549bc6945f814080b6ee7df4c00",
+      "version-semver": "1.0.0",
+      "port-version": 1
+    },
     {
       "git-tree": "4dbeca9676a469cb84eb1cfc731ae9bbc9110447",
       "version-semver": "0.20.0",

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/gamedev-framework/portfile.cmake

github-actions[bot]
github-actions bot previously approved these changes Jul 18, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/gamedev-framework/portfile.cmake

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

All manifest files must be formatted

./vcpkg format-manifest ports/*/vcpkg.json

Diff
diff --git a/ports/gamedev-framework/vcpkg.json b/ports/gamedev-framework/vcpkg.json
index dea633c..6a3b70d 100644
--- a/ports/gamedev-framework/vcpkg.json
+++ b/ports/gamedev-framework/vcpkg.json
@@ -30,7 +30,6 @@
       "platform": "!linux"
     },
     "stb",
-    "zlib",
     {
       "name": "vcpkg-cmake",
       "host": true
@@ -38,6 +37,7 @@
     {
       "name": "vcpkg-cmake-config",
       "host": true
-    }
+    },
+    "zlib"
   ]
 }
PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for gamedev-framework have changed but the version was not updated
version: 1.0.0#1
old SHA: 3e567182a4df1549bc6945f814080b6ee7df4c00
new SHA: 35bdc1f38ab201cafa93bd644a930b65dfbed062
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for gamedev-framework have changed but the version was not updated
version: 1.0.0#1
old SHA: 3e567182a4df1549bc6945f814080b6ee7df4c00
new SHA: 35bdc1f38ab201cafa93bd644a930b65dfbed062
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for gamedev-framework have changed but the version was not updated
version: 1.0.0#2
old SHA: 35bdc1f38ab201cafa93bd644a930b65dfbed062
new SHA: 21c1e1161d7ea766e4ba00992d325d3defab58a5
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

github-actions[bot]
github-actions bot previously approved these changes Jul 18, 2022
@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Jul 19, 2022
ports/gamedev-framework/vcpkg.json Outdated Show resolved Hide resolved
ports/gamedev-framework/portfile.cmake Outdated Show resolved Hide resolved
ahugeat and others added 2 commits July 19, 2022 18:27
Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>
Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout de176433e9a8769eed0e43d61758f4cdc1dc6e20 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index 01326d0..9edd8df 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -2450,7 +2450,7 @@
     },
     "gamedev-framework": {
       "baseline": "1.0.0",
-      "port-version": 2
+      "port-version": 0
     },
     "gamenetworkingsockets": {
       "baseline": "1.4.1",
diff --git a/versions/g-/gamedev-framework.json b/versions/g-/gamedev-framework.json
index c92a404..86bd5a9 100644
--- a/versions/g-/gamedev-framework.json
+++ b/versions/g-/gamedev-framework.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "66a45568c161b8eb5ae64471a466545b96b15818",
+      "version-semver": "1.0.0",
+      "port-version": 0
+    },
     {
       "git-tree": "21c1e1161d7ea766e4ba00992d325d3defab58a5",
       "version-semver": "1.0.0",

@ahugeat
Copy link
Contributor Author

ahugeat commented Jul 19, 2022

@JonLiu1993 thanks for your review. I have commited the changements.

github-actions[bot]
github-actions bot previously approved these changes Jul 19, 2022
@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Jul 20, 2022
@vicroms vicroms merged commit 645b853 into microsoft:master Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants