Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[glib] Support static build on Windows. #25937

Merged
merged 6 commits into from
Aug 4, 2022

Conversation

BillyONeal
Copy link
Member

@BillyONeal BillyONeal commented Jul 22, 2022

As suggested by @Neumann-A; the indicated PR has landed upstream.

@BillyONeal BillyONeal added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Jul 22, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout e8bbe813151e45077fa70887b1f87ccce514701a -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index 807bb06..e7eaa09 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -2586,7 +2586,7 @@
     },
     "glib": {
       "baseline": "2.72.3",
-      "port-version": 0
+      "port-version": 1
     },
     "glibmm": {
       "baseline": "2.70.0",
diff --git a/versions/g-/glib.json b/versions/g-/glib.json
index 263cbaa..2a5d4ff 100644
--- a/versions/g-/glib.json
+++ b/versions/g-/glib.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "76099eb6e007c8015b04c3f2906148d635406b10",
+      "version": "2.72.3",
+      "port-version": 1
+    },
     {
       "git-tree": "abff8e76676673462462f949844d3369d93be61d",
       "version": "2.72.3",

@BillyONeal
Copy link
Member Author

Fixes #22842

github-actions[bot]
github-actions bot previously approved these changes Jul 22, 2022
@Neumann-A
Copy link
Contributor

@BillyONeal ci.baseline:

glib:x64-uwp=fail
glib:x64-windows-static=fail

github-actions[bot]
github-actions bot previously approved these changes Jul 22, 2022
@LilyWangLL LilyWangLL self-assigned this Jul 25, 2022
REGRESSION: atk:x64-windows-static failed with BUILD_FAILED. If expected, add atk:x64-windows-static=fail to C:\a\1\s\scripts\azure-pipelines/../ci.baseline.txt.
REGRESSION: gdk-pixbuf:x64-windows-static failed with BUILD_FAILED. If expected, add gdk-pixbuf:x64-windows-static=fail to C:\a\1\s\scripts\azure-pipelines/../ci.baseline.txt.
REGRESSION: glibmm:x64-windows-static failed with BUILD_FAILED. If expected, add glibmm:x64-windows-static=fail to C:\a\1\s\scripts\azure-pipelines/../ci.baseline.txt.
REGRESSION: glibmm:x64-windows-static-md failed with BUILD_FAILED. If expected, add glibmm:x64-windows-static-md=fail to C:\a\1\s\scripts\azure-pipelines/../ci.baseline.txt.
REGRESSION: gstreamer:x64-windows-static failed with BUILD_FAILED. If expected, add gstreamer:x64-windows-static=fail to C:\a\1\s\scripts\azure-pipelines/../ci.baseline.txt.
REGRESSION: gstreamer:x64-windows-static-md failed with BUILD_FAILED. If expected, add gstreamer:x64-windows-static-md=fail to C:\a\1\s\scripts\azure-pipelines/../ci.baseline.txt.
REGRESSION: lcm:x64-windows-static-md failed with BUILD_FAILED. If expected, add lcm:x64-windows-static-md=fail to C:\a\1\s\scripts\azure-pipelines/../ci.baseline.txt.
REGRESSION: libgxps:x64-windows-static-md failed with BUILD_FAILED. If expected, add libgxps:x64-windows-static-md=fail to C:\a\1\s\scripts\azure-pipelines/../ci.baseline.txt.
Previously blocked by glib supports expression.

REGRESSION: mfl:x64-windows-static-md failed with BUILD_FAILED. If expected, add mfl:x64-windows-static-md=fail to C:\a\1\s\scripts\azure-pipelines/../ci.baseline.txt.
This was not blocked before but it's an ICE; I'm going to hope it's intermittent I guess?

Drive by fixed alphabetizing boringssl.
github-actions[bot]
github-actions bot previously approved these changes Aug 3, 2022
@BillyONeal
Copy link
Member Author

@ras0219 reviewed this over my shoulder

@BillyONeal BillyONeal merged commit 4288609 into microsoft:master Aug 4, 2022
@BillyONeal BillyONeal deleted the glib-static branch August 4, 2022 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants