Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libmariadb] Fix features #26077

Merged
merged 6 commits into from
Aug 3, 2022
Merged

[libmariadb] Fix features #26077

merged 6 commits into from
Aug 3, 2022

Conversation

Thomas1664
Copy link
Contributor

@Thomas1664 Thomas1664 commented Jul 31, 2022 •
edited
Loading

Describe the pull request

  • What does your PR fix?

    Use supports for feature schannel

Note that this PR is not tested in CI because libmariadb conflicts with libmysql. I tested that the right features for the corresponding platform are set locally.

github-actions[bot]
github-actions bot previously approved these changes Jul 31, 2022
View reviewed changes
@JackBoosY JackBoosY added the category:port-bug The issue is with a library, which is something the port should already support label Aug 1, 2022
JackBoosY
JackBoosY previously approved these changes Aug 1, 2022
View reviewed changes
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Aug 1, 2022
ras0219-msft
ras0219-msft previously requested changes Aug 2, 2022
View reviewed changes
Copy link
Contributor

@ras0219-msft ras0219-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also want to give @dg0yt a chance to comment on this -- my understanding is that mingw intends for all Win32 APIs (including SChannel) to work.

ports/libmariadb/vcpkg.json Outdated Show resolved Hide resolved
@ras0219-msft ras0219-msft added requires:author-response and removed info:reviewed Pull Request changes follow basic guidelines labels Aug 2, 2022
@dg0yt
Copy link
Contributor

dg0yt commented Aug 3, 2022

  • Feature schannel doesn't work on mingw.

libmariadb[core,schannel] builds SCHANNEL support without problems in MSYS2 with a recent mingw-w64.
#26059 refers to a Linux host. It may have an older version of mingw-w64. (e.g. Ubuntu 18.04 is too old.)
So the change to supports is wrong, and IMO even the default shouldn't be changed for mingw.

@Thomas1664 Thomas1664 closed this Aug 3, 2022
@Thomas1664 Thomas1664 reopened this Aug 3, 2022
dg0yt
dg0yt approved these changes Aug 3, 2022
View reviewed changes
Copy link
Contributor

@dg0yt dg0yt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@JackBoosY JackBoosY added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Aug 3, 2022
@JavierMatosD JavierMatosD merged commit 7122b74 into microsoft:master Aug 3, 2022
@JavierMatosD
Copy link
Contributor

Thanks!

@Thomas1664 Thomas1664 deleted the libmariadb branch August 3, 2022 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@dg0yt dg0yt dg0yt approved these changes

@JackBoosY JackBoosY JackBoosY left review comments

@ras0219-msft ras0219-msft Awaiting requested review from ras0219-msft

Assignees

@JackBoosY JackBoosY

Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Thomas1664 @dg0yt @JavierMatosD @ras0219-msft @JackBoosY